Closed mortengrouleff closed 5 months ago
Merging #309 (cde5f8f) into master (c76455c) will decrease coverage by
0.17%
. Report is 5 commits behind head on master. The diff coverage is100.00%
.
Thanks! Merging it
less code that was covered increased the share of uncovered code, and there is some :)
Just published 1.5.6-3 with that fix
Even when using a by-reference buffer, the dict struct itself is malloc'ed and thus needs freeing to not leak memory.
The leak is fairly slow, as it leaks the size of the
struct ZSTD_CDict_s
(andZSTD_DDict_s
for decompress) on every use, which takes quite a few rounds to become visible as an increase in overall process size.The issue affects exclusively uses of the (new in v1.5.6-2)
getByReferenceBuffer
variants. I would like to request a version bump and a new published build to allow using this downstream.Fixes: https://github.com/luben/zstd-jni/issues/310