Add flag to open QS instantly in the webbrowser

lubianat / pyorcidator

MIT License

9 stars 5 forks source link

Add flag to open QS instantly in the webbrowser #12

Closed jvfe closed 2 years ago

jvfe commented 2 years ago

docs: Add correct command in README
feat: Add flag to open browser with QuickStatements
style: Sort imports on src/

cthoyt commented 2 years ago

@jvfe this is great! you could consider adding the following to pyproject.toml to make isort and black have an explicit styling:

[tool.black]
line-length = 100
target-version = ["py37", "py38", "py39", "py310"]

[tool.isort]
profile = "black"
multi_line_output = 3
line_length = 100
include_trailing_comma = true
reverse_relative = true

jvfe commented 2 years ago

@jvfe this is great! you could consider adding the following to pyproject.toml to make isort and black have an explicit styling:
[tool.black]
line-length = 100
target-version = ["py37", "py38", "py39", "py310"]

[tool.isort]
profile = "black"
multi_line_output = 3
line_length = 100
include_trailing_comma = true
reverse_relative = true

Hi, thank you! I've added that to the TOML file.

jvfe commented 2 years ago

BTW, had to do some ugly rebasing + squashing to fix the conflicts after 52550f23bc62c590c4c790aed9789fd7372d0972 - hence the force pushes - but this PR's commit history is still the same and I don't believe I've broken anything.

cthoyt commented 2 years ago

The simple solution for projects with more than one contributor is to always use "squash and merge" which turns all commits in a PR into exactly one commit in the main branch.