search

lubianat / pyorcidator

MIT License
9 stars 5 forks source link

Small code clean up #32

Closed cthoyt closed 2 years ago

cthoyt commented 2 years ago

This PR does the following:

  1. Makes the paths to the curated data files more accessible
  2. Remove mutable default in helper.py's get_external_ids()
  3. Replace prints with proper logging
  4. Add more __all__ annotations
  5. Support unicode characters in JSON dumps
lubianat commented 2 years ago

Actually this small cleanup broke the package for python 3.8. It is failing to load the dicts.

Not sure why, but I really want to keep this compatible with python 3.8.

Any thoughts on what might be breaking?

cthoyt commented 2 years ago

@lubianat oh that's a bummer. can we add CI for Python 3.8 if compatibility is a goal?

I can't imagine why this would be problematic for py38 specifically, unless maybe I did a new-style type annotation somewhere