lubianat / pyorcidator

MIT License
8 stars 5 forks source link

Improve handling and skipping when term not present in Wikidata #49

Open lubianat opened 1 year ago

lubianat commented 1 year ago

Sometimes a term is not on Wikidata and we'd rather just exclude it instead of going through the effort of creating a new entry.

Not sure about how to implement:

jvfe commented 1 year ago

I prefer the second option. Having keys in our dict that don't refer to Q-Ids would be a big change from the current data model. Another idea is having a third option when receiving the prompt, e.g:

Is the QID for 'Systems Biology'  
 Q815297 - systems biology (computational and mathematical modeling of complex biological systems) ? (y/n/skip)
lubianat commented 1 year ago

Yeah, I like this option. And one could set a general "skip" flag to just treat all of them as skips. Tiago

On Fri, Oct 14, 2022 at 11:14 AM João Vitor @.***> wrote:

I prefer the second option. Having keys in our dict that don't refer to Q-Ids would be a big change from the current data model. Another idea is having a third option when receiving the prompt, e.g:

Is the QID for 'Systems Biology' Q815297 - systems biology (computational and mathematical modeling of complex biological systems) ? (y/n/skip)

— Reply to this email directly, view it on GitHub https://github.com/lubianat/pyorcidator/issues/49#issuecomment-1279067045, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4NC7YU3FYF2VN7NKNTXRTWDFTD3ANCNFSM6AAAAAARFIY4BY . You are receiving this because you authored the thread.Message ID: @.***>

cthoyt commented 1 year ago

Agreed, having a skip option would be nice.

jvfe commented 1 year ago

I believe the implementation would be more appropriate inside of add_key in wdcuration.py, since that function is the one that generates the prompts to the user.