search

lubritto / flutter_share

A Flutter plugin for IOS and Android providing a simple way to share a message, link or local files.
MIT License
40 stars 45 forks source link

Fixes issue #8 #11

Closed neokree closed 4 years ago

neokree commented 4 years ago

This pull request fixes the app crashing when share is called from an iPad (#8).

Since the plugin was developed before the introduction of the latest stable versione of flutter (v1.12.13), some commit about the migration of that version were also added.

You can find a detailed description of why I have done something directly in commit messages.

Let me know if you have questions about some edits. I hope that this pull request can be integrated as soon as possible since I have an app in production that requires this fix.

lubritto commented 4 years ago

Hello, can you check if your issue is fixed using the master?

neokree commented 4 years ago

As the comment on #8, no the issue is not fixed on master.

However, since the other pull request was also merged, I will create a new pull request with the code to fix it