More descriptive variable names

lubusIN / composer-edd-plugin

Composer plugin for installing pro plugins powered by EDD software licensing

MIT License

13 stars 3 forks source link

Open szepeviktor opened 4 years ago

szepeviktor commented 4 years ago

            "license_var": "PRODUCT_LICENSE",
            "url_var": "PRODUCT_ACTIVATION_URL"

Could we rename these two?

szepeviktor commented 3 years ago

@ajitbohra adding _var would show that it is not a value but a variable name. Please.

ajitbohra commented 3 years ago

sounds good we can rename for more clarity and also support the existing one for backward compatibility.