search

lubusIN / laravel-gymie

👨‍💻 Gym & Club Management System https://gymie.in
MIT License
421 stars 248 forks source link

Using paginator Instance Method "total" for counting records #42

Closed imanghafoori1 closed 6 years ago

imanghafoori1 commented 6 years ago

More info: https://laravel.com/docs/5.6/pagination#paginator-instance-methods

ludo237 commented 6 years ago

Good 👍 but please next time use a better title and description 😆

ajitbohra commented 6 years ago

@ludo237 yes 💯 and thanks for pointing in the right direction will help in reducing unnecessary queries & less code :)

@imanghafoori1 have updated the title & description try to keep it simple & easy to refer :) thanks for working on this I guess we can carry similar refactoring across the codebase.

I guess we can close #39 seems to be redundant.

imanghafoori1 commented 6 years ago

@ajitbohra All fixed