luc-ass / homebridge-evohome

Homebridge plugin for Honeywell Evohome
29 stars 16 forks source link

Fixing bug in `getTemperatureDisplayUnits` #141

Closed georgesdib closed 1 year ago

georgesdib commented 1 year ago

replaced = by ==, this error meant that the TemperatureDisplayUnit was always Fahrenheit no matter what the setup is.

Also, fixed setTemperatureDisplayUnits to be able to set a different unit.

Fixes #142

@luc-ass

luc-ass commented 1 year ago

LGTM, have you tested this?

georgesdib commented 1 year ago

LGTM, have you tested this?

Yes I did

georgesdib commented 1 year ago

If all looks good, shall we merge it?

luc-ass commented 1 year ago

sorry, forgot about that ;)