luc-ass / homebridge-evohome

Homebridge plugin for Honeywell Evohome
29 stars 16 forks source link

Support Domestic Hot Water #143

Closed georgesdib closed 1 year ago

georgesdib commented 1 year ago

Added 2 HomeKit accessories, a temperature sensor and a switch to support Evohome Domestic Hot Water.

Also added history logging for Eve.

Changed the behaviour of the valve for the thermostat to be 100% when it's heating and 0% when it's not.

Fixes #80

SeaneyC commented 1 year ago

Whoa nice updates! I’ll give it a look when I can, I have a tank/circuit. Many thanks all!

On Sat, 18 Feb 2023 at 12:50, Georges @.***> wrote:

Added 2 HomeKit accessory, a temperature sensor and a switch to support Evohome Domestic Hot Water.

Also added history logging for Eve.

Changed the behaviour of the valve for the thermostat to be 100% when it's heating and 0% when it's not.

You can view, comment on, or merge this pull request online at:

https://github.com/luc-ass/homebridge-evohome/pull/143 Commit Summary

File Changes

(2 files https://github.com/luc-ass/homebridge-evohome/pull/143/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/luc-ass/homebridge-evohome/pull/143, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT4A6BPRIM6QVMBXOE6J2FDWYDAS7ANCNFSM6AAAAAAVAKSA6I . You are receiving this because you are subscribed to this thread.Message ID: @.***>

5xPa commented 1 year ago

Have applied the update, I don't see anything to do with the Hotwater system. Is there something I need to enable?

georgesdib commented 1 year ago

Have applied the update, I don't see anything to do with the Hotwater system. Is there something I need to enable?

After I updated the code, I just went to my home app and I could see the hot water temperature sensor and switch. Are you not able to see that at all? Not to state the obvious, but you are using it on a location that has hot water?

5xPa commented 1 year ago

Hi Yes I have evohome control of hotwater tank

Here is a copy of the log as Evohome connects [18/02/2023, 15:00:15] [Evohome] Loaded homebridge-evohome v0.10.2 child bridge successfully [18/02/2023, 15:00:15] Loaded 0 cached accessories from cachedAccessories.0E3B232C36DD. [18/02/2023, 15:00:15] [Evohome] Logging into Evohome... [18/02/2023, 15:00:26] [Evohome] Logged into Evohome! [18/02/2023, 15:00:32] [Evohome] You have 1 location(s). This instance will be using Index No 0 [18/02/2023, 15:00:32] [Evohome] You have 10 device(s). [18/02/2023, 15:00:35] [homebridge-evohome] This plugin is taking long time to load and preventing Homebridge from starting. See https://homebridge.io/w/JtMGR for more info. [18/02/2023, 15:00:38] [Evohome] 0: Living Room (20°) [18/02/2023, 15:00:38] [Evohome] 1: Dining room (20°) [18/02/2023, 15:00:38] [Evohome] 2: Kitchen (20°) [18/02/2023, 15:00:38] [Evohome] 3: Hall Front (20°) [18/02/2023, 15:00:38] [Evohome] 4: Agnes Bed (18°) [18/02/2023, 15:00:38] [Evohome] 5: Scott Bed (16.5°) [18/02/2023, 15:00:38] [Evohome] 6: Small Bed (15.5°) [18/02/2023, 15:00:38] [Evohome] 7: Bathroom (20°) [18/02/2023, 15:00:38] [Evohome] 8: Garage (12.5°) [18/02/2023, 15:00:38] [Evohome] 9: Shed (10°) [18/02/2023, 15:00:38] Initializing platform accessory 'Living Room Thermostat'... [18/02/2023, 15:00:38] Initializing platform accessory 'Dining room Thermostat'... [18/02/2023, 15:00:38] Initializing platform accessory 'Kitchen Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Hall Front Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Agnes Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Scott Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Small Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Bathroom Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Garage Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Shed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Away Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Day Off Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Heating Off Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Eco Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Custom Mode'... [18/02/2023, 15:00:39] Homebridge v1.6.0 (HAP v0.11.0) (Evohome) is running on port 56862. [18/02/2023, 15:05:02] [Homebridge UI] Changes to config.json saved. [18/02/2023, 15:05:06] [Homebridge UI] Homebridge restart request received

On Sat, 18 Feb 2023 at 15:23, Georges @.***> wrote:

Have applied the update, I don't see anything to do with the Hotwater system. Is there something I need to enable?

After I updated the code, I just went to my home app and I could see the hot water temperature sensor and switch. Are you not able to see that at all? Not to state the obvious, but you are using it on a location that has hot water?

— Reply to this email directly, view it on GitHub https://github.com/luc-ass/homebridge-evohome/pull/143#issuecomment-1435699187, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARF3VCA76MLVS7DK2ZCFQRTWYDSN5ANCNFSM6AAAAAAVAKSA6I . You are receiving this because you commented.Message ID: @.***>

SeaneyC commented 1 year ago

Just so i’m clear, this hasn’t been merged into main yet has it? So the update won’t have made it to Homebridge yet, if that’s what you’ve updated?

On Sat, 18 Feb 2023 at 15:48, 5xPa @.***> wrote:

Hi Yes I have evohome control of hotwater tank

Here is a copy of the log as Evohome connects [18/02/2023, 15:00:15] [Evohome] Loaded homebridge-evohome v0.10.2 child bridge successfully [18/02/2023, 15:00:15] Loaded 0 cached accessories from cachedAccessories.0E3B232C36DD. [18/02/2023, 15:00:15] [Evohome] Logging into Evohome... [18/02/2023, 15:00:26] [Evohome] Logged into Evohome! [18/02/2023, 15:00:32] [Evohome] You have 1 location(s). This instance will be using Index No 0 [18/02/2023, 15:00:32] [Evohome] You have 10 device(s). [18/02/2023, 15:00:35] [homebridge-evohome] This plugin is taking long time to load and preventing Homebridge from starting. See https://homebridge.io/w/JtMGR for more info. [18/02/2023, 15:00:38] [Evohome] 0: Living Room (20°) [18/02/2023, 15:00:38] [Evohome] 1: Dining room (20°) [18/02/2023, 15:00:38] [Evohome] 2: Kitchen (20°) [18/02/2023, 15:00:38] [Evohome] 3: Hall Front (20°) [18/02/2023, 15:00:38] [Evohome] 4: Agnes Bed (18°) [18/02/2023, 15:00:38] [Evohome] 5: Scott Bed (16.5°) [18/02/2023, 15:00:38] [Evohome] 6: Small Bed (15.5°) [18/02/2023, 15:00:38] [Evohome] 7: Bathroom (20°) [18/02/2023, 15:00:38] [Evohome] 8: Garage (12.5°) [18/02/2023, 15:00:38] [Evohome] 9: Shed (10°) [18/02/2023, 15:00:38] Initializing platform accessory 'Living Room Thermostat'... [18/02/2023, 15:00:38] Initializing platform accessory 'Dining room Thermostat'... [18/02/2023, 15:00:38] Initializing platform accessory 'Kitchen Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Hall Front Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Agnes Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Scott Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Small Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Bathroom Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Garage Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Shed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Away Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Day Off Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Heating Off Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Eco Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Custom Mode'... [18/02/2023, 15:00:39] Homebridge v1.6.0 (HAP v0.11.0) (Evohome) is running on port 56862. [18/02/2023, 15:05:02] [Homebridge UI] Changes to config.json saved. [18/02/2023, 15:05:06] [Homebridge UI] Homebridge restart request received

On Sat, 18 Feb 2023 at 15:23, Georges @.***> wrote:

Have applied the update, I don't see anything to do with the Hotwater system. Is there something I need to enable?

After I updated the code, I just went to my home app and I could see the hot water temperature sensor and switch. Are you not able to see that at all? Not to state the obvious, but you are using it on a location that has hot water?

— Reply to this email directly, view it on GitHub < https://github.com/luc-ass/homebridge-evohome/pull/143#issuecomment-1435699187 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ARF3VCA76MLVS7DK2ZCFQRTWYDSN5ANCNFSM6AAAAAAVAKSA6I

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/luc-ass/homebridge-evohome/pull/143#issuecomment-1435703831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT4A6BPMCFHD64ATH2UOHX3WYDVOLANCNFSM6AAAAAAVAKSA6I . You are receiving this because you commented.Message ID: @.***>

georgesdib commented 1 year ago

Just so i’m clear, this hasn’t been merged into main yet has it? So the update won’t have made it to Homebridge yet, if that’s what you’ve updated?

That is correct, it has not been merged to main yet. @5xPa are you using the official plugin from homebridge? If so, then indeed, it won't be there yet. You need to use this branch's code to have it.

5xPa commented 1 year ago

Hi Thanks for the reply, I just went into Homebridge and selected update to homebridge-evohome v0.10.2

I don't know how to update any other way.

On Sat, 18 Feb 2023 at 15:51, SeaneyC @.***> wrote:

Just so i’m clear, this hasn’t been merged into main yet has it? So the update won’t have made it to Homebridge yet, if that’s what you’ve updated?

On Sat, 18 Feb 2023 at 15:48, 5xPa @.***> wrote:

Hi Yes I have evohome control of hotwater tank

Here is a copy of the log as Evohome connects [18/02/2023, 15:00:15] [Evohome] Loaded homebridge-evohome v0.10.2 child bridge successfully [18/02/2023, 15:00:15] Loaded 0 cached accessories from cachedAccessories.0E3B232C36DD. [18/02/2023, 15:00:15] [Evohome] Logging into Evohome... [18/02/2023, 15:00:26] [Evohome] Logged into Evohome! [18/02/2023, 15:00:32] [Evohome] You have 1 location(s). This instance will be using Index No 0 [18/02/2023, 15:00:32] [Evohome] You have 10 device(s). [18/02/2023, 15:00:35] [homebridge-evohome] This plugin is taking long time to load and preventing Homebridge from starting. See https://homebridge.io/w/JtMGR for more info. [18/02/2023, 15:00:38] [Evohome] 0: Living Room (20°) [18/02/2023, 15:00:38] [Evohome] 1: Dining room (20°) [18/02/2023, 15:00:38] [Evohome] 2: Kitchen (20°) [18/02/2023, 15:00:38] [Evohome] 3: Hall Front (20°) [18/02/2023, 15:00:38] [Evohome] 4: Agnes Bed (18°) [18/02/2023, 15:00:38] [Evohome] 5: Scott Bed (16.5°) [18/02/2023, 15:00:38] [Evohome] 6: Small Bed (15.5°) [18/02/2023, 15:00:38] [Evohome] 7: Bathroom (20°) [18/02/2023, 15:00:38] [Evohome] 8: Garage (12.5°) [18/02/2023, 15:00:38] [Evohome] 9: Shed (10°) [18/02/2023, 15:00:38] Initializing platform accessory 'Living Room Thermostat'... [18/02/2023, 15:00:38] Initializing platform accessory 'Dining room Thermostat'... [18/02/2023, 15:00:38] Initializing platform accessory 'Kitchen Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Hall Front Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Agnes Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Scott Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Small Bed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Bathroom Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Garage Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Shed Thermostat'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Away Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Day Off Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Heating Off Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Eco Mode'... [18/02/2023, 15:00:39] Initializing platform accessory 'Evohome Custom Mode'... [18/02/2023, 15:00:39] Homebridge v1.6.0 (HAP v0.11.0) (Evohome) is running on port 56862. [18/02/2023, 15:05:02] [Homebridge UI] Changes to config.json saved. [18/02/2023, 15:05:06] [Homebridge UI] Homebridge restart request received

On Sat, 18 Feb 2023 at 15:23, Georges @.***> wrote:

Have applied the update, I don't see anything to do with the Hotwater system. Is there something I need to enable?

After I updated the code, I just went to my home app and I could see the hot water temperature sensor and switch. Are you not able to see that at all? Not to state the obvious, but you are using it on a location that has hot water?

— Reply to this email directly, view it on GitHub <

https://github.com/luc-ass/homebridge-evohome/pull/143#issuecomment-1435699187

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ARF3VCA76MLVS7DK2ZCFQRTWYDSN5ANCNFSM6AAAAAAVAKSA6I

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/luc-ass/homebridge-evohome/pull/143#issuecomment-1435703831 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AT4A6BPMCFHD64ATH2UOHX3WYDVOLANCNFSM6AAAAAAVAKSA6I

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/luc-ass/homebridge-evohome/pull/143#issuecomment-1435704270, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARF3VCGBMWGYOUTC2LIUU6DWYDVXXANCNFSM6AAAAAAVAKSA6I . You are receiving this because you commented.Message ID: @.***>

5xPa commented 1 year ago

How do I i?nstall a branch

On Sat, 18 Feb 2023 at 15:55, Georges @.***> wrote:

Just so i’m clear, this hasn’t been merged into main yet has it? So the update won’t have made it to Homebridge yet, if that’s what you’ve updated? … <#m-8301007509611088718>

That is correct, it has not been merged to main yet. @5xPa https://github.com/5xPa are you using the official plugin from homebridge? If so, then indeed, it won't be there yet. You need to use this branch's code to have it.

— Reply to this email directly, view it on GitHub https://github.com/luc-ass/homebridge-evohome/pull/143#issuecomment-1435704888, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARF3VCH3G2GKTCWDHO6JM4DWYDWFRANCNFSM6AAAAAAVAKSA6I . You are receiving this because you were mentioned.Message ID: @.***>

georgesdib commented 1 year ago

How do I i?nstall a branch

I would strongly advise running a second homebridge for that to not mess up with your production setup. If you don't feel comfortable for that, I would say don't test it yet.

Otherwise, if you have a separate homebridge running, you need to find where the plugins are installed, and override the homebridge-evohome files by the ones here and then restart homebridge (or only the sub bridge if you are running a sub bridge).

5xPa commented 1 year ago

Hi Thanks for the replies, I shall do as you advise and wait until the standard version has hotwater control

On Sat, 18 Feb 2023 at 16:51, Georges @.***> wrote:

How do I i?nstall a branch … <#m875641225860886518>

I would strongly advise running a second homebridge for that to not mess up with your production setup. If you don't feel comfortable for that, I would say don't test it yet.

Otherwise, if you have a separate homebridge running, you need to find where the plugins are installed, and override the homebridge-evohome files by the ones here and then restart homebridge (or only the sub bridge if you are running a sub bridge).

— Reply to this email directly, view it on GitHub https://github.com/luc-ass/homebridge-evohome/pull/143#issuecomment-1435715337, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARF3VCHYB6XILOLXIUPROKDWYD4YBANCNFSM6AAAAAAVAKSA6I . You are receiving this because you were mentioned.Message ID: @.***>

luc-ass commented 1 year ago

Hey there. This is awesome news!! As I do not have the hot water unit I have not way of testing. How long have you been running it? Is it stable?

georgesdib commented 1 year ago

Hey there. This is awesome news!! As I do not have the hot water unit I have not way of testing. How long have you been running it? Is it stable?

I have been running it for a couple of weeks now, seems pretty stable to me yes. Please note I also changed the way the valve for a regular thermostat reports (instead of hardcoding to 50%, make it 100 or 0 based on if targetTemp >= currentTemp

luc-ass commented 1 year ago

Great! I'll review the changes in the coming days and merge it back into the project. Thank you so much for your hard work!

luc-ass commented 1 year ago

LGTM, will test it over the weekend

luc-ass commented 1 year ago

@georgesdib I've released your additions and fixes as v0.11.0. Thank you!! :rocket:

5xPa commented 1 year ago

Brilliant can now view Hotwater in HomeKit. Thanks for all the effort