luc-ass / homebridge-evohome

Homebridge plugin for Honeywell Evohome
29 stars 16 forks source link

Trying to fix crash at startup #15

Closed rooi closed 7 years ago

brownad commented 7 years ago

nice :+1:

luc-ass commented 7 years ago

Did you manage to get things working with temperature below 10 °C?

brownad commented 7 years ago

You sure this works for you below 10 °C?

Do I need to remove and add it all again, am on latest published version and still blows up when under 10 °C

rooi commented 7 years ago

I just tried to fix the crash at startup. I just checked and temp < 10 does not seem to work. Homekit's thermostat does not seem to respond to any min max or step settings.

I also tried the following, but no luck (even when setting minTemp to 15):

    this.thermostatService.getCharacteristic(Characteristic.CurrentTemperature)
    .setProps({
              minValue: this.minTemp,
              maxValue: this.maxTemp,
              minStep: 0.5
              });

    // this.addCharacteristic(Characteristic.TargetTemperature); READ WRITE
    this.thermostatService
        .getCharacteristic(Characteristic.TargetTemperature)
        .on('get', this.getTargetTemperature.bind(this))
        .on('set', this.setTargetTemperature.bind(this));

    this.thermostatService.getCharacteristic(Characteristic.TargetTemperature)
    .setProps({
              minValue: this.minTemp,
              maxValue: this.maxTemp,
              minStep: 0.5
              });
brownad commented 7 years ago

Cool, thought I was the only one :|