luc-demeyer / noviat-apps

Noviat apps.odoo.com repository
20 stars 53 forks source link

Odoo v9 #14

Open alaa9jo opened 8 years ago

alaa9jo commented 8 years ago

It would be great if these modules support odoo v9

luc-demeyer commented 8 years ago

Porting work is in progress.

ddormal commented 8 years ago

Dear,

Do you have an ETA for the Belgian cash discount module for Odoo 9?

Thanks in advance

luc-demeyer commented 8 years ago

No date for that one yet. We have only a very limited set of our customers requiring this module and it's not in the specs of currently ongoing V9 projects in our customer base. If you have funding for the port, than we can move it forward, otherwise this module will be probably not be ported before Q4 of this year.

ddormal commented 8 years ago

I'll be happy to participate on the development of this module. It depends on the price and delay of course. I found a small issue with the accounting entries. May be I can explain that via mail if you want.

luc-demeyer commented 8 years ago

Ok. Send me an e-mail (luc.demeyer@noviat.com)

ddormal commented 8 years ago

Dear Luc,

Sorry for the delay.

I attached 3 screenshot of an invoice, its related accounting entries and the paramters of belgian cash discount module.

In the first screenshot (check the time), you will see that the article line of the invoice has a 600000 accounting account. Since there is a belgian cash discount for this supplier, the tax base should be 98% of the article untaxed amount. This is done correctly in your module. What I think is not exactly as it should be is the treatment of the remaining 2%. Here, the this amount (0,12 euro see picture 2) is set in the account mentioned as parameter (picture 3). Doing so, the module will set the account mentioned in picture 3 as the account related to the 2% remaining no matter which account is set in the first place (in the invoice). So if you have an invoice with 2 lines, one being a 61xxxx account and the other one a 60xxx account, they will both be summed in the "escompte financier" line and get the same accouting account mentioned in picture 3. To me, this is not correct and they should each have a separate line with their respective account (60xxx and 61xxx) and of course no tax account since this 2% parts are not subject to VAT.

I hope I made myself clear. I would be happy to help the community with this upgrade so could you send a quotation with expected delay for this upgrade to odoo 9 and (if we agree on this) the bug fix?

Don't hesitate to call me if you need further info on this.

Kind regards.

Dorian Dormal

Square Larousse 18 B-1190 BRUXELLES Gsm : +32 (0) 474 91 51 32 e-mail : ddormal@gmail.com

On Sun, May 22, 2016 at 9:34 PM, Luc De Meyer notifications@github.com wrote:

Ok. Send me an e-mail (luc.demeyer@noviat.com)

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/luc-demeyer/noviat-apps/issues/14#issuecomment-220851355

luc-demeyer commented 8 years ago

Dear Dorian,

When I made the module originally, I did the functional design with a specialist of an accountancy firm, hence I am not sure if your suggestion is correct. You should configure the 'Incoming Invoice Cash Discount Account' on a 65xxxx account (hence NOT on 60 nor 61). I can change the current behaviour but I would like to have statement from an external accountant or a clear description in a book of e.g. Deloitte, Kluwer, ... that says that the current implementation is not correct.

Concerning port to V9: I estimate +/- one day of work when keeping current functional approach. Seen the fact that our resources are fully booked we could deliver this port by the end of september the earliest.