search

luc-github / ESP3D-Configurator

GNU General Public License v3.0
8 stars 5 forks source link

Comment out comments in platformio.ini #8

Closed aj3t4m closed 1 year ago

luc-github commented 2 years ago

Thank you but it is currently done on purpose the flash mode configuration is not yet implemented in configurator so I left to default some esp32 actually only support 160MHz and other need different flash mode like opi

image

That is why these setting are in comment to let user to change if needed if default used by platformio are not working I need to find some time to implement them in configurator for esp32 according version

aj3t4m commented 1 year ago

This commit only comments out real comments "set frequency to 240MHz" is not an ini setting but a comment. Without that for some configurations you get broken ini file.

luc-github commented 1 year ago

ho boy why I cannot read that properly? my comment is non sense sorry ....need coffee... thank you

luc-github commented 1 year ago

@all-contributors please add @aj3t4m for bug fix

allcontributors[bot] commented 1 year ago

@luc-github

I've put up a pull request to add @aj3t4m! :tada:

luc-github commented 1 year ago

@all-contributors please add @aj3t4m for code fix also

allcontributors[bot] commented 1 year ago

@luc-github

I've put up a pull request to add @aj3t4m! :tada: