search

luc-github / ESP3D-TFT

ESP3D Firmware for ESP32 based TFT
GNU General Public License v3.0
38 stars 9 forks source link

Fix loading of Settings -> Extensions into editor #21

Closed serisman closed 1 year ago

serisman commented 1 year ago

This is a bug fix for another minor issue I found.

I noticed that when going to the Settings screen and then clicking on the Edit button for Extensions that the value loaded into the editor was mangled. Leaving this screen then saved the wrong value.

I believe this is because the extensions label is being loaded async so lv_label_get_text(extensions_label) doesn't actually have a valid value when the button handler is wired up (lv_obj_add_event_cb). Just moving lv_label_get_text(extensions_label) into the event handler seems to fix the issue, but obviously feel free to fix this a different way if needed.

luc-github commented 1 year ago

Thank you I got issue only once and was not able to reproduced it , so I did not dig in, merged Thank you