search

luc-github / ESP3D-TFT

ESP3D Firmware for ESP32 based TFT
GNU General Public License v3.0
38 stars 9 forks source link

Use combined bsp folders for Sunton_ESP32 and Sunton_ESP32-S3 targets respectively #39

Closed serisman closed 7 months ago

serisman commented 1 year ago

@luc-github - This PR is an attempt at simplifying the hardware directory even further.

I combined the ESP32_3248S035C, ESP32_3248S035R, and ESP32_2432S028R targets into a single SUNTON_ESP32 bsp folder. I have fully tested all three of these targets with these changes applied and haven't found any issues.

I also combined the ESP32S3_8048S070C, ESP32S3_8048S050C, ESP32S3_8048S043C, and ESP32S3_4827S043C targets into a single SUNTON_ESP32-S3 bsp folder. This should also make it easier to eventually add the missing ESP32S3_4827S043R if desired. I have not tested any of these boards, but the code does compile for each option. The original bsp target folders were already really close to each other, and I was pretty careful on comparing all the variations, so I'm 99% confident that these still work without any new regressions.

I think this gets closer to what you mentioned the other day, although we may want to take it even further.

This also removes the warning for the non-PSRAM targets now that they seem to be working well again.

luc-github commented 7 months ago

I did new modular file org so this PR won't be pushed - on going doc to explain org arch is here : https://github.com/luc-github/ESP3D-TFT/blob/main/docs/project-arch.md