Modify ESP32S3-BZM-TFT35_GT911 to SPI screen

[liqijian101]

I have modified ESP32S3-BZM-TFT35_GT911 to SPI screen. However, the following error is currently being prompted:

ESP-ERROR-CHECK failed: esp_err_t 0x105 (ESP-ERR-NOT-FOUND) at 0x4202ccda
File: "./main/modules/serial/esp3d_serial_client. cpp" line 165
Func: virtual bool ESP3DSerialClient:: begin()
Expression: uart_driver-install (ESP3D-SERIAL-PORT, ESP3D-SERIAL-RX-BUFFER-SIZE * 2, ESP3D-SERIAL-TX-BUFFER-SIZE, 0, NULL, intr-alloc_flags)
Abort() was called at PC 0x4037f973 on core 0

If I annotate the following code for esp3d_tft.cpp，there will be no errors success = esp3dTftstream.begin();

[luc-github]

@liqijian101 please check my fix

It compile fine on my side

 Executing task: cmake -G Ninja -DPYTHON_DEPS_CHECKED=1 -DESP_PLATFORM=1 -B c:\Users\luc\Documents\GitHub\ESP3D-TFT\build -S c:\Users\luc\Documents\GitHub\ESP3D-TFT 

-- Found Git: C:/Users/luc/.espressif/tools/idf-git/2.39.2/cmd/git.exe (found version "2.39.2.windows.1") 
-- 
-- ----Project definition----
-- PROJECT_NAME =  ESP3D TFT
-- TFT_TARGET = ESP32S3_BZM_TFT35_GT911
-- IDF_TARGET = esp32s3
-- --------------------------
-- 
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- The ASM compiler identification is GNU
-- Found assembler: C:/Users/luc/.espressif/tools/xtensa-esp32s3-elf/esp-12.2.0_20230208/xtensa-esp32s3-elf/bin/xtensa-esp32s3-elf-gcc.exe
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Users/luc/.espressif/tools/xtensa-esp32s3-elf/esp-12.2.0_20230208/xtensa-esp32s3-elf/bin/xtensa-esp32s3-elf-gcc.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Users/luc/.espressif/tools/xtensa-esp32s3-elf/esp-12.2.0_20230208/xtensa-esp32s3-elf/bin/xtensa-esp32s3-elf-g++.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Building ESP-IDF components for target esp32s3
Processing 7 dependencies:
[1/7] espressif/esp32-camera (2.0.8)
[2/7] espressif/usb_host_cdc_acm (2.0.2~1)
[3/7] espressif/usb_host_ch34x_vcp (2.0.0)
[4/7] espressif/usb_host_cp210x_vcp (2.0.0)
[5/7] espressif/usb_host_ftdi_vcp (2.0.0)
[6/7] espressif/usb_host_vcp (1.0.0~2)
[7/7] idf (5.1.2)
-- Project sdkconfig file C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/ESP32S3_BZM_TFT35_GT911/sdkconfig
Compiler supported targets: xtensa-esp32s3-elf

-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of time_t
-- Check size of time_t - done
-- Found Python3: C:/Users/luc/.espressif/python_env/idf5.1_py3.11_env/Scripts/python.exe (found version "3.11.2") found components: Interpreter 
-- Performing Test C_COMPILER_SUPPORTS_WFORMAT_SIGNEDNESS
-- Performing Test C_COMPILER_SUPPORTS_WFORMAT_SIGNEDNESS - Success
-- App "ESP3D-TFT" version: 98b95ae1-dirty
-- Adding linker script C:/Users/luc/Documents/GitHub/ESP3D-TFT/build/esp-idf/esp_system/ld/memory.ld
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_system/ld/esp32s3/sections.ld.in
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_rom/esp32s3/ld/esp32s3.rom.ld
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_rom/esp32s3/ld/esp32s3.rom.api.ld
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_rom/esp32s3/ld/esp32s3.rom.libgcc.ld
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_rom/esp32s3/ld/esp32s3.rom.newlib.ld
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_rom/esp32s3/ld/esp32s3.rom.version.ld
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/soc/esp32s3/ld/esp32s3.peripherals.ld
-- Components: SSDP_IDF app_trace app_update bootloader bootloader_support bsp bt camera cmock console cxx disp_backlight disp_spi driver efuse esp-tls esp3d_log esp_adc esp_app_format esp_coex esp_common esp_eth esp_event esp_gdbstub esp_hid esp_http_client esp_http_server esp_https_ota esp_https_server esp_hw_support esp_lcd esp_littlefs esp_local_ctrl esp_mm esp_netif esp_netif_stack esp_partition esp_phy esp_pm esp_psram esp_ringbuf esp_rom esp_system esp_timer esp_wifi espcoredump espressif__esp32-camera espressif__usb_host_cdc_acm espressif__usb_host_ch34x_vcp espressif__usb_host_cp210x_vcp espressif__usb_host_ftdi_vcp espressif__usb_host_vcp esptool_py fatfs freertos ft5x06 gt911 hal heap http_parser i2c_bus idf_test ieee802154 ili9341 json log lvgl lwip main mbedtls mdns mqtt newlib nvs_flash openthread partition_table perfmon protobuf-c protocomm pthread sdmmc soc spi_bus spi_flash spiffs st7796 sw_spi tca9554 tcp_transport touch_element ulp unity usb usb_serial vfs wear_levelling wifi_provisioning wpa_supplicant xpt2046 xtensa
-- Component paths: C:/Users/luc/Documents/GitHub/ESP3D-TFT/components/SSDP_IDF C:/Users/luc/esp/v5.1.2/esp-idf/components/app_trace C:/Users/luc/esp/v5.1.2/esp-idf/components/app_update C:/Users/luc/esp/v5.1.2/esp-idf/components/bootloader C:/Users/luc/esp/v5.1.2/esp-idf/components/bootloader_support C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/ESP32S3_BZM_TFT35_GT911/components/bsp C:/Users/luc/esp/v5.1.2/esp-idf/components/bt C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_common/camera C:/Users/luc/esp/v5.1.2/esp-idf/components/cmock C:/Users/luc/esp/v5.1.2/esp-idf/components/console C:/Users/luc/esp/v5.1.2/esp-idf/components/cxx C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_common/disp_backlight C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_common/disp_spi C:/Users/luc/esp/v5.1.2/esp-idf/components/driver C:/Users/luc/esp/v5.1.2/esp-idf/components/efuse C:/Users/luc/esp/v5.1.2/esp-idf/components/esp-tls C:/Users/luc/Documents/GitHub/ESP3D-TFT/components/esp3d_log C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_adc C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_app_format C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_coex C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_common C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_eth C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_event C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_gdbstub C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_hid C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_http_client C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_http_server C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_https_ota C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_https_server C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_hw_support C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_lcd C:/Users/luc/Documents/GitHub/ESP3D-TFT/components/esp_littlefs C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_local_ctrl C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_mm C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_netif C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_netif_stack C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_partition C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_phy C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_pm C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_psram C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_ringbuf C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_rom C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_system C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_timer C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_wifi C:/Users/luc/esp/v5.1.2/esp-idf/components/espcoredump C:/Users/luc/Documents/GitHub/ESP3D-TFT/managed_components/espressif__esp32-camera C:/Users/luc/Documents/GitHub/ESP3D-TFT/managed_components/espressif__usb_host_cdc_acm C:/Users/luc/Documents/GitHub/ESP3D-TFT/managed_components/espressif__usb_host_ch34x_vcp C:/Users/luc/Documents/GitHub/ESP3D-TFT/managed_components/espressif__usb_host_cp210x_vcp C:/Users/luc/Documents/GitHub/ESP3D-TFT/managed_components/espressif__usb_host_ftdi_vcp C:/Users/luc/Documents/GitHub/ESP3D-TFT/managed_components/espressif__usb_host_vcp C:/Users/luc/esp/v5.1.2/esp-idf/components/esptool_py C:/Users/luc/esp/v5.1.2/esp-idf/components/fatfs C:/Users/luc/esp/v5.1.2/esp-idf/components/freertos C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_common/ft5x06 C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_common/gt911 C:/Users/luc/esp/v5.1.2/esp-idf/components/hal C:/Users/luc/esp/v5.1.2/esp-idf/components/heap C:/Users/luc/esp/v5.1.2/esp-idf/components/http_parser C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_common/i2c_bus C:/Users/luc/esp/v5.1.2/esp-idf/components/idf_test C:/Users/luc/esp/v5.1.2/esp-idf/components/ieee802154 C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_common/ili9341 C:/Users/luc/esp/v5.1.2/esp-idf/components/json C:/Users/luc/esp/v5.1.2/esp-idf/components/log C:/Users/luc/Documents/GitHub/ESP3D-TFT/components/lvgl C:/Users/luc/esp/v5.1.2/esp-idf/components/lwip C:/Users/luc/Documents/GitHub/ESP3D-TFT/main C:/Users/luc/esp/v5.1.2/esp-idf/components/mbedtls C:/Users/luc/Documents/GitHub/ESP3D-TFT/components/mdns C:/Users/luc/esp/v5.1.2/esp-idf/components/mqtt C:/Users/luc/esp/v5.1.2/esp-idf/components/newlib C:/Users/luc/esp/v5.1.2/esp-idf/components/nvs_flash C:/Users/luc/esp/v5.1.2/esp-idf/components/openthread C:/Users/luc/esp/v5.1.2/esp-idf/components/partition_table C:/Users/luc/esp/v5.1.2/esp-idf/components/perfmon C:/Users/luc/esp/v5.1.2/esp-idf/components/protobuf-c C:/Users/luc/esp/v5.1.2/esp-idf/components/protocomm C:/Users/luc/esp/v5.1.2/esp-idf/components/pthread C:/Users/luc/esp/v5.1.2/esp-idf/components/sdmmc C:/Users/luc/esp/v5.1.2/esp-idf/components/soc C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_common/spi_bus C:/Users/luc/esp/v5.1.2/esp-idf/components/spi_flash C:/Users/luc/esp/v5.1.2/esp-idf/components/spiffs C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_common/st7796 C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_common/sw_spi C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_common/tca9554 C:/Users/luc/esp/v5.1.2/esp-idf/components/tcp_transport C:/Users/luc/esp/v5.1.2/esp-idf/components/touch_element C:/Users/luc/esp/v5.1.2/esp-idf/components/ulp C:/Users/luc/esp/v5.1.2/esp-idf/components/unity C:/Users/luc/esp/v5.1.2/esp-idf/components/usb C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_usb_otg/usb_serial C:/Users/luc/esp/v5.1.2/esp-idf/components/vfs C:/Users/luc/esp/v5.1.2/esp-idf/components/wear_levelling C:/Users/luc/esp/v5.1.2/esp-idf/components/wifi_provisioning C:/Users/luc/esp/v5.1.2/esp-idf/components/wpa_supplicant C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/drivers_common/xpt2046 C:/Users/luc/esp/v5.1.2/esp-idf/components/xtensa
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Users/luc/Documents/GitHub/ESP3D-TFT/build

 *  Executing task: ninja  

[35/1385] Generating ../../partition_table/partition-table.bin
Partition table binary generated. Contents:
*******************************************************************************
# ESP-IDF Partition Table
# Name, Type, SubType, Offset, Size, Flags
nvs,data,nvs,0x9000,20K,
otadata,data,ota,0xe000,8K,
app0,app,ota_0,0x10000,2112K,
app1,app,ota_1,0x220000,2112K,
flashfs,data,spiffs,0x430000,3712K,
*******************************************************************************
[644/1385] Performing configure step for 'bootloader'
-- Found Git: C:/Users/luc/.espressif/tools/idf-git/2.39.2/cmd/git.exe (found version "2.39.2.windows.1")
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- The ASM compiler identification is GNU
-- Found assembler: C:/Users/luc/.espressif/tools/xtensa-esp32s3-elf/esp-12.2.0_20230208/xtensa-esp32s3-elf/bin/xtensa-esp32s3-elf-gcc.exe
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Users/luc/.espressif/tools/xtensa-esp32s3-elf/esp-12.2.0_20230208/xtensa-esp32s3-elf/bin/xtensa-esp32s3-elf-gcc.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Users/luc/.espressif/tools/xtensa-esp32s3-elf/esp-12.2.0_20230208/xtensa-esp32s3-elf/bin/xtensa-esp32s3-elf-g++.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Building ESP-IDF components for target esp32s3
-- Project sdkconfig file C:/Users/luc/Documents/GitHub/ESP3D-TFT/hardware/ESP32S3_BZM_TFT35_GT911/sdkconfig
Compiler supported targets: xtensa-esp32s3-elf

-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of time_t
-- Check size of time_t - done
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/soc/esp32s3/ld/esp32s3.peripherals.ld
-- App "bootloader" version: v5.1.2
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_rom/esp32s3/ld/esp32s3.rom.ld
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_rom/esp32s3/ld/esp32s3.rom.api.ld
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_rom/esp32s3/ld/esp32s3.rom.libgcc.ld
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_rom/esp32s3/ld/esp32s3.rom.newlib.ld
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/bootloader/subproject/main/ld/esp32s3/bootloader.ld
-- Adding linker script C:/Users/luc/esp/v5.1.2/esp-idf/components/bootloader/subproject/main/ld/esp32s3/bootloader.rom.ld
-- Components: bootloader bootloader_support efuse esp_app_format esp_common esp_hw_support esp_rom esp_system esptool_py freertos hal log main micro-ecc newlib partition_table soc spi_flash xtensa
-- Component paths: C:/Users/luc/esp/v5.1.2/esp-idf/components/bootloader C:/Users/luc/esp/v5.1.2/esp-idf/components/bootloader_support C:/Users/luc/esp/v5.1.2/esp-idf/components/efuse C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_app_format C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_common C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_hw_support C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_rom C:/Users/luc/esp/v5.1.2/esp-idf/components/esp_system C:/Users/luc/esp/v5.1.2/esp-idf/components/esptool_py C:/Users/luc/esp/v5.1.2/esp-idf/components/freertos C:/Users/luc/esp/v5.1.2/esp-idf/components/hal C:/Users/luc/esp/v5.1.2/esp-idf/components/log C:/Users/luc/esp/v5.1.2/esp-idf/components/bootloader/subproject/main C:/Users/luc/esp/v5.1.2/esp-idf/components/bootloader/subproject/components/micro-ecc C:/Users/luc/esp/v5.1.2/esp-idf/components/newlib C:/Users/luc/esp/v5.1.2/esp-idf/components/partition_table C:/Users/luc/esp/v5.1.2/esp-idf/components/soc C:/Users/luc/esp/v5.1.2/esp-idf/components/spi_flash C:/Users/luc/esp/v5.1.2/esp-idf/components/xtensa
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Users/luc/Documents/GitHub/ESP3D-TFT/build/bootloader
[689/1385] Performing build step for 'bootloader'
[1/110] Generating project_elf_src_esp32s3.c
[2/110] Building C object esp-idf/xtensa/CMakeFiles/__idf_xtensa.dir/xt_trax.c.obj
[3/110] Building C object esp-idf/xtensa/CMakeFiles/__idf_xtensa.dir/eri.c.obj
[4/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/gpio_periph.c.obj
[5/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/interrupts.c.obj
[6/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/dport_access_common.c.obj
[7/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/uart_periph.c.obj
[8/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/lldesc.c.obj
[9/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/adc_periph.c.obj
[10/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/gdma_periph.c.obj
[11/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/dedic_gpio_periph.c.obj
[12/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/spi_periph.c.obj
[13/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/ledc_periph.c.obj
[14/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/pcnt_periph.c.obj
[15/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/rmt_periph.c.obj
[16/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/i2c_periph.c.obj
[17/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/sdm_periph.c.obj
[18/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/i2s_periph.c.obj
[19/110] Building C object CMakeFiles/bootloader.elf.dir/project_elf_src_esp32s3.c.obj
[20/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/temperature_sensor_periph.c.obj
[21/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/timer_periph.c.obj
[22/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/lcd_periph.c.obj
[23/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/mcpwm_periph.c.obj
[24/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/touch_sensor_periph.c.obj
[25/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/sdmmc_periph.c.obj
[26/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/twai_periph.c.obj
[27/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/usb_periph.c.obj
[28/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/usb_otg_periph.c.obj
[29/110] Building C object esp-idf/soc/CMakeFiles/__idf_soc.dir/esp32s3/rtc_io_periph.c.obj
[30/110] Building C object esp-idf/hal/CMakeFiles/__idf_hal.dir/esp32s3/efuse_hal.c.obj
[31/110] Building C object esp-idf/hal/CMakeFiles/__idf_hal.dir/mpu_hal.c.obj
[32/110] Building C object esp-idf/hal/CMakeFiles/__idf_hal.dir/efuse_hal.c.obj
[33/110] Building C object esp-idf/hal/CMakeFiles/__idf_hal.dir/mmu_hal.c.obj
[34/110] Building C object esp-idf/hal/CMakeFiles/__idf_hal.dir/cache_hal.c.obj
[35/110] Building C object esp-idf/spi_flash/CMakeFiles/__idf_spi_flash.dir/spi_flash_wrap.c.obj
[36/110] Building C object esp-idf/esp_app_format/CMakeFiles/__idf_esp_app_format.dir/esp_app_desc.c.obj
[37/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_common.c.obj
[38/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_common_loader.c.obj
[39/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/secure_boot.c.obj
[40/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/bootloader_flash/src/bootloader_flash_config_esp32s3.c.obj
[41/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/bootloader_flash/src/flash_qio_mode.c.obj
[42/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_random.c.obj
[43/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_random_esp32s3.c.obj
[44/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_efuse.c.obj
[45/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_clock_init.c.obj
[46/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_mem.c.obj
[47/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/flash_encrypt.c.obj
[48/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/flash_partitions.c.obj
[49/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_init.c.obj
[50/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/esp32s3/bootloader_sha.c.obj
[51/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_console.c.obj
[52/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_clock_loader.c.obj
[53/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_console_loader.c.obj
[54/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/esp32s3/bootloader_soc.c.obj
[55/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/bootloader_flash/src/bootloader_flash.c.obj
[56/110] Building C object esp-idf/esp_hw_support/CMakeFiles/__idf_esp_hw_support.dir/esp_memory_utils.c.obj
[57/110] Building C object esp-idf/esp_hw_support/CMakeFiles/__idf_esp_hw_support.dir/cpu.c.obj
[58/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_panic.c.obj
[59/110] Building C object esp-idf/efuse/CMakeFiles/__idf_efuse.dir/esp32s3/esp_efuse_table.c.obj
[60/110] Building C object esp-idf/efuse/CMakeFiles/__idf_efuse.dir/esp32s3/esp_efuse_fields.c.obj
[61/110] Building C object esp-idf/efuse/CMakeFiles/__idf_efuse.dir/esp32s3/esp_efuse_utility.c.obj
[62/110] Building C object esp-idf/micro-ecc/CMakeFiles/__idf_micro-ecc.dir/uECC_verify_antifault.c.obj
[63/110] Building C object esp-idf/efuse/CMakeFiles/__idf_efuse.dir/src/esp_efuse_fields.c.obj
[64/110] Building C object esp-idf/efuse/CMakeFiles/__idf_efuse.dir/esp32s3/esp_efuse_rtc_calib.c.obj
[65/110] Building C object esp-idf/esp_system/CMakeFiles/__idf_esp_system.dir/esp_err.c.obj
[66/110] Building C object esp-idf/esp_hw_support/CMakeFiles/__idf_esp_hw_support.dir/port/esp32s3/rtc_clk_init.c.obj
[67/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/bootloader_utility.c.obj
[68/110] Building C object esp-idf/esp_hw_support/CMakeFiles/__idf_esp_hw_support.dir/port/esp32s3/cpu_region_protect.c.obj
[69/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/esp_image_format.c.obj
[70/110] Building C object esp-idf/bootloader_support/CMakeFiles/__idf_bootloader_support.dir/src/esp32s3/bootloader_esp32s3.c.obj
[71/110] Building C object esp-idf/esp_hw_support/CMakeFiles/__idf_esp_hw_support.dir/port/esp32s3/chip_info.c.obj
[72/110] Building C object esp-idf/esp_rom/CMakeFiles/__idf_esp_rom.dir/patches/esp_rom_crc.c.obj
[73/110] Building C object esp-idf/esp_rom/CMakeFiles/__idf_esp_rom.dir/patches/esp_rom_efuse.c.obj
[74/110] Building C object esp-idf/esp_rom/CMakeFiles/__idf_esp_rom.dir/patches/esp_rom_spiflash.c.obj
[75/110] Building C object esp-idf/esp_rom/CMakeFiles/__idf_esp_rom.dir/patches/esp_rom_sys.c.obj
[76/110] Building C object esp-idf/efuse/CMakeFiles/__idf_efuse.dir/src/esp_efuse_api.c.obj
[77/110] Building C object esp-idf/esp_rom/CMakeFiles/__idf_esp_rom.dir/patches/esp_rom_systimer.c.obj
[78/110] Building ASM object esp-idf/esp_rom/CMakeFiles/__idf_esp_rom.dir/patches/esp_rom_longjmp.S.obj
[79/110] Building C object esp-idf/efuse/CMakeFiles/__idf_efuse.dir/src/esp_efuse_utility.c.obj
[80/110] Building C object esp-idf/efuse/CMakeFiles/__idf_efuse.dir/src/efuse_controller/keys/with_key_purposes/esp_efuse_api_key.c.obj
[81/110] Building ASM object esp-idf/esp_rom/CMakeFiles/__idf_esp_rom.dir/patches/esp_rom_cache_writeback_esp32s3.S.obj
[82/110] Building C object esp-idf/esp_common/CMakeFiles/__idf_esp_common.dir/src/esp_err_to_name.c.obj
[83/110] Building C object esp-idf/esp_hw_support/CMakeFiles/__idf_esp_hw_support.dir/port/esp32s3/rtc_time.c.obj
[84/110] Building C object esp-idf/esp_hw_support/CMakeFiles/__idf_esp_hw_support.dir/port/esp32s3/rtc_sleep.c.obj
[85/110] Building C object esp-idf/esp_hw_support/CMakeFiles/__idf_esp_hw_support.dir/port/esp32s3/rtc_clk.c.obj
[86/110] Building C object esp-idf/esp_rom/CMakeFiles/__idf_esp_rom.dir/patches/esp_rom_uart.c.obj
[87/110] Building C object esp-idf/esp_hw_support/CMakeFiles/__idf_esp_hw_support.dir/port/esp32s3/rtc_init.c.obj
[88/110] Building C object esp-idf/esp_rom/CMakeFiles/__idf_esp_rom.dir/patches/esp_rom_wdt.c.obj
[89/110] Building C object esp-idf/esp_rom/CMakeFiles/__idf_esp_rom.dir/patches/esp_rom_cache_esp32s2_esp32s3.c.obj
[90/110] Building C object esp-idf/log/CMakeFiles/__idf_log.dir/log_noos.c.obj
[91/110] Building C object esp-idf/main/CMakeFiles/__idf_main.dir/bootloader_start.c.obj
[92/110] Building C object esp-idf/log/CMakeFiles/__idf_log.dir/log.c.obj
[93/110] Building C object esp-idf/log/CMakeFiles/__idf_log.dir/log_buffers.c.obj
[94/110] Linking C static library esp-idf\log\liblog.a
[95/110] Linking C static library esp-idf\esp_rom\libesp_rom.a
[96/110] Linking C static library esp-idf\esp_common\libesp_common.a
[97/110] Linking C static library esp-idf\esp_hw_support\libesp_hw_support.a
[98/110] Linking C static library esp-idf\esp_system\libesp_system.a
[99/110] Linking C static library esp-idf\efuse\libefuse.a
[100/110] Linking C static library esp-idf\bootloader_support\libbootloader_support.a
[101/110] Linking C static library esp-idf\esp_app_format\libesp_app_format.a
[102/110] Linking C static library esp-idf\spi_flash\libspi_flash.a
[103/110] Linking C static library esp-idf\hal\libhal.a
[104/110] Linking C static library esp-idf\micro-ecc\libmicro-ecc.a
[105/110] Linking C static library esp-idf\soc\libsoc.a
[106/110] Linking C static library esp-idf\xtensa\libxtensa.a
[107/110] Linking C static library esp-idf\main\libmain.a
[108/110] Linking C executable bootloader.elf
[109/110] Generating binary image from built executable
esptool.py v4.7.0
Creating esp32s3 image...
Merged 1 ELF section
Successfully created esp32s3 image.
Generated C:/Users/luc/Documents/GitHub/ESP3D-TFT/build/bootloader/bootloader.bin
[110/110] cmd.exe /C "cd /D C:\Users\luc\Documents\GitHub\ESP3D-TFT\build\bootloader\esp-idf\esptool_py && C:\Users\luc\.espressif\python_env\idf5.1_py3.11_env\Scripts\python.exe C:/Users/luc/esp/v5.1.2/esp-idf/components/partition_table/check_sizes.py --offset 0x8000 bootloader 0x0 C:/Users/luc/Documents/GitHub/ESP3D-TFT/build/bootloader/bootloader.bin"
Bootloader binary size 0x38d0 bytes. 0x4730 bytes (56%) free.
[1384/1385] Generating binary image from built executable
esptool.py v4.7.0
Creating esp32s3 image...
Merged 2 ELF sections
Successfully created esp32s3 image.
Generated C:/Users/luc/Documents/GitHub/ESP3D-TFT/build/ESP3D-TFT.bin
[1385/1385] cmd.exe /C "cd /D C:\Users\luc\Documents\GitHub\ESP3D-TFT\build\esp-idf\esptool...tion_table/partition-table.bin C:/Users/luc/Documents/GitHub/ESP3D-TFT/build/ESP3D-TFT.bin" 
ESP3D-TFT.bin binary size 0x2018c0 bytes. Smallest app partition is 0x210000 bytes. 0xe740 bytes (3%) free.
Warning: The smallest app partition is nearly full (3% free space left)!

[liqijian101]

It's not a compilation error. It returns an error message on the serial port

[luc-github]

Well before it was not compiling neither

If it is runtime error I do not have your board so I cannot reproduce - more over serial is same for all boards so it may be wiring issue / pin conflict Did you try basic arduino sketch for serial on this board to valicdate it works ?

[liqijian101]

Before this update, I was able to run all functions correctly, including TFT, camera, and serial port

[luc-github]

it is not same board if you changed so many pins - I see you even changed sdkconfig - the issue is may be there

[liqijian101]

It seems that interrupts cannot be allocated. The problem may not necessarily be with the serial port here, it may be that the interrupt is occupied elsewhere

[luc-github]

Yes as I mention you modified sdkconfig, revert it because several changes make no sense

[liqijian101]

revert it because several changes make no sense

Having the same problem。

[luc-github]

Try using same value as esp32 : .dma_channel = 1, instead of Auto as you mention disable TFT make it work

Sorry without board to test, I dry to guess

[liqijian101]

Try using same value as esp32 : .dma_channel = 1

It will be another mistake。

If I annotate add_compile_options (- DWith_GT91d_INT=1), the problem will be resolved.

[luc-github]

yes seems 1 and 2 are only for ESP32 and you are using S3

typedef enum {
  SPI_DMA_DISABLED = 0,     ///< Do not enable DMA for SPI
#if CONFIG_IDF_TARGET_ESP32
  SPI_DMA_CH1      = 1,     ///< Enable DMA, select DMA Channel 1
  SPI_DMA_CH2      = 2,     ///< Enable DMA, select DMA Channel 2
#endif
  SPI_DMA_CH_AUTO  = 3,     ///< Enable DMA, channel is automatically selected by driver
} spi_common_dma_t;

try with 0 then

[luc-github]

also if now you drop the rgb /i80 screen to use spi you better disable related settings in sdkconfig

[liqijian101]

After disabling DMA, TFT refresh is very slow and cannot solve this issues.

[luc-github]

then keep dma auto and search in sdkconfig what could cause the issue

[liqijian101]

I think disabling the INT of the GT911 is sufficient. After testing, no impact was found

[luc-github]

I think disabling the INT of the GT911 is sufficient. After testing, no impact was found

Ok if you think it is the solution - just let me know when your PR is ready to be merged

Also does it make your previous board end of Life ? Also what about http://esp3d.io/esp3d-tft/v1.x/hardware/esp32-s3/bzm-35-4832/index.html ?

[liqijian101]

I think disabling the INT of the GT911 is sufficient. After testing, no impact was found

Ok if you think it is the solution - just let me know when your PR is ready to be merged

Also does it make your previous board end of Life ? Also what about http://esp3d.io/esp3d-tft/v1.x/hardware/esp32-s3/bzm-35-4832/index.html ?

Yes,the PR is ready to be merged。 The previous motherboard will be discarded, and I will update it

[liqijian101]

Now, except for the USB HOST CDC not working properly, everything else is working properly。 I found that the initialization code for usb_serial is not completely consistent with the instance https://github.com/espressif/esp-idf/blob/master/examples/peripherals/usb/host/cdc/cdc_acm_vcp/main/cdc_acm_vcp_example_main.cpp

[luc-github]

what is the issue ? be noted reference code should be 5.1 not master https://github.com/espressif/esp-idf/blob/release/v5.1/examples/peripherals/usb/host/cdc/cdc_acm_vcp/main/cdc_acm_vcp_example_main.cpp

[liqijian101]

Rebooting... ESP-ROM:esp32s3-20210327 Build:Mar 27 2021 rst:0x3 (RTC_SW_SYS_RST),boot:0x1a (SPI_FAST_FLASH_BOOT) Saved PC:0x40385a17 SPIWP:0xee mode:DIO, clock div:1 load:0x3fce3818,len:0x508 load:0x403c9700,len:0x4 load:0x403c9704,len:0xad0 load:0x403cc700,len:0x288c entry 0x403c9880 ESP_ERROR_CHECK failed: esp_err_t 0x105 (ESP_ERR_NOT_FOUND) at 0x42084661 file: "./managed_components/espressif__usb_host_cdc_acm/cdc_acm_host.c" line 897 func: cdc_acm_host_close expression: cdc_acm_reset_transfer_endpoint(cdc_dev->dev_hdl, cdc_dev->data.in_xfer)

abort() was called at PC 0x40382cfb on core 1

Backtrace: 0x40379d32:0x3fcd1a90 0x40382d05:0x3fcd1ab0 0x4038a242:0x3fcd1ad0 0x40382cfb:0x3fcd1b40 0x42084661:0x3fcd1b70 0x4209b2df:0x3fcd1b90 0x4209b304:0x3fcd1bb0 0x4209b311:0x3fcd1bd0 0x4215d82d:0x3fcd1bf0 0x4202fd54:0x3fcd1c10 0x4202fdb1:0x3fcd1c60

[luc-github]

what idf core are you using ?

[liqijian101]

5.1.2

[luc-github]

do you have same issue if you disable TFT and camera ?

# #######################################
# Select the Features
# #######################################
OPTION(ESP3D_AUTHENTICATION "Authentication on all clients" OFF)
OPTION(DISABLE_SERIAL_AUTHENTICATION "Disable Serial Authentication" ON)
OPTION(TIME_SERVICE  "Time service" ON)
OPTION(SSDP_SERVICE "SSDP service" ON)
OPTION(MDNS_SERVICE "MDNS service" ON)
OPTION(WIFI_SERVICE "WiFi service" ON)
OPTION(BT_SERVICE "Bluetooth service" ON)
OPTION(WEB_SERVICES "Web Services http/websocket/webdav/camera" ON)
OPTION(CAMERA_SERVICE "Camera service" OFF)
OPTION(WEBDAV_SERVICES "WebDav Services" ON)
OPTION(TELNET_SERVICE "Telnet service" ON)
OPTION(WS_SERVICE "WebSocket data service" ON)
OPTION(TFT_UI_SERVICE "TFT UI service" OFF)
OPTION(SD_CARD_SERVICE "SD card service" ON)
OPTION(NOTIFICATIONS_SERVICE "Notifications service" ON)
OPTION(UPDATE_SERVICE "Update service" ON)
OPTION(USB_SERIAL_SERVICE "Use USB Serial if Available" ON)
OPTION(USE_FAT_INSTEAD_OF_LITTLEFS "Use FAT instead of LittleFS" OFF)

[liqijian101]

It is the same problem

do you have same issue if you disable TFT and camera ?

[luc-github]

ok because like this I may try to reproduce on normal S3 because no more hardware dependency Will check today

[luc-github]

Using a ESP32-S3

# #######################################
# Select the targeted hardware
# #######################################

# With TFT:
OPTION(ESP32S3_HMI43V3 "TFT TARGET is ESP32S3 HMI 4.3inches" OFF)
OPTION(ESP32_ROTRICS_DEXARM35 "TFT TARGET is ESP32 Rotrics DexArm 3.5inches" OFF)
OPTION(ESP32S3_ZX3D50CE02S_USRC_4832 "TFT TARGET is ESP32S3 Panlee ZX3D50CE02S-SRC-4832 3.5inches" OFF)
OPTION(ESP32S3_BZM_TFT35_GT911 "TFT TARGET is ESP32S3 Panlee BZM 3.5inches" ON)
OPTION(ESP32S3_8048S070C "TFT TARGET is ESP32S3_8048S070C - 7.0in. 800x480 (Capacitive)" OFF)
OPTION(ESP32S3_8048S050C "TFT TARGET is ESP32S3_8048S050C - 5.0in. 800x480 (Capacitive)" OFF)
OPTION(ESP32S3_8048S043C "TFT TARGET is ESP32S3_8048S043C - 4.3in. 800x480 (Capacitive)" OFF)
OPTION(ESP32S3_4827S043C "TFT TARGET is ESP32S3_4827S043C - 4.3in. 480x272 (Capacitive)" OFF)
OPTION(ESP32_3248S035C "TFT TARGET is ESP32_3248S035C - 3.5in. 480x320 (Capacitive)" OFF)
OPTION(ESP32_3248S035R "TFT TARGET is ESP32_3248S035R - 3.5in. 480x320 (Resistive)"  OFF)
OPTION(ESP32_2432S028R "TFT TARGET is ESP32_2432S028R - 2.8in. 320x240 (Resistive)" OFF)

# Without TFT:
OPTION(ESP32S3_FREENOVE_1_1 "HARDWARE TARGET is ESP32S3 Freenove v1.1" OFF)
OPTION(ESP32S3_SEEED_STUDIO_XIAO  "HARDWARE TARGET is ESP32S3 Seeed Studio Xiao Sense" OFF)
OPTION(ESP32S3_CUSTOM "HARDWARE TARGET is ESP32S3 custom board" OFF)
OPTION(ESP32_CUSTOM "HARDWARE TARGET is ESP32 custom board" OFF)

# #######################################
# Optionally: Select hardware mods applied
# #######################################
#only for ESP32S3_8048S070C OR ESP32S3_8048S050C OR ESP32S3_8048S043C OR ESP32S3_4827S043C OR ESP32_3248S035C
OPTION(HARDWARE_MOD_GT911_INT "Hardware Mod: GT911 INT pin" OFF)

#Only for ESP32_3248S035C OR ESP32_3248S035R OR ESP32_2432S028R
# 4MB Flash, no PSRAM by default
OPTION(HARDWARE_MOD_8MB_FLASH "Hardware Mod: 8MB Flash Upgrade" OFF)
OPTION(HARDWARE_MOD_16MB_FLASH "Hardware Mod: 16MB Flash Upgrade" OFF)
OPTION(HARDWARE_MOD_EXT_PSRAM "Hardware Mod: External PSRAM" OFF)

# #######################################
# Select the targeted firmware
# #######################################
OPTION(TARGET_FW_MARLIN "Marlin firmware" ON)
OPTION(TARGET_FW_REPETIER "Repetier firmware" OFF)
OPTION(TARGET_FW_SMOOTHIEWARE "Smoothieware firmware" OFF)
OPTION(TARGET_FW_GRBL "GRBL firmware" OFF)

# #######################################
# Select the Features
# #######################################
OPTION(ESP3D_AUTHENTICATION "Authentication on all clients" OFF)
OPTION(DISABLE_SERIAL_AUTHENTICATION "Disable Serial Authentication" ON)
OPTION(TIME_SERVICE  "Time service" ON)
OPTION(SSDP_SERVICE "SSDP service" ON)
OPTION(MDNS_SERVICE "MDNS service" ON)
OPTION(WIFI_SERVICE "WiFi service" ON)
OPTION(BT_SERVICE "Bluetooth service" ON)
OPTION(WEB_SERVICES "Web Services http/websocket/webdav/camera" ON)
OPTION(CAMERA_SERVICE "Camera service" OFF)
OPTION(WEBDAV_SERVICES "WebDav Services" ON)
OPTION(TELNET_SERVICE "Telnet service" ON-)
OPTION(WS_SERVICE "WebSocket data service" ON)
OPTION(TFT_UI_SERVICE "TFT UI service" OFF)
OPTION(SD_CARD_SERVICE "SD card service" ON)
OPTION(NOTIFICATIONS_SERVICE "Notifications service" ON)
OPTION(UPDATE_SERVICE "Update service" ON)
OPTION(USB_SERIAL_SERVICE "Use USB Serial if Available" ON)
OPTION(USE_FAT_INSTEAD_OF_LITTLEFS "Use FAT instead of LittleFS" OFF)

# #######################################
# Do not change anything below this line
# #######################################
cmake_minimum_required(VERSION 3.12.4)
set(CMAKE_CXX_STANDARD 20)

include (cmake/targets.cmake)

include($ENV{IDF_PATH}/tools/cmake/project.cmake)

include (cmake/features.cmake)

project(ESP3D-TFT
    VERSION 1.0
    DESCRIPTION "ESP3D TFT")

I cannot duplicate

No error and USB communication is working

[liqijian101]

Under the condition of disabling the camera and TFT, ESP3D-TFT can indeed work. I set the wrong baud rate, which is why the above error occurred. ESP3D-TFT can work when the camera is enabled but TFT is disabled. If the camera and TFT are enabled, ESP3D TFT will continue to run incorrectly。 I don't think TFT is necessary。 The camera and USBHOST are a better combination. This will save money on touch screens

[luc-github]

I set the wrong baud rate, which is why the above error occurred.

I did also and cannot duplicate the issue, communication failed but no such error

If the camera and TFT are enabled, ESP3D TFT will continue to run incorrectly。

That not clear - what the issue ? error ? performances ? crash ? please elaborate

The camera and USBHOST are a better combination. This will save money on touch screens

That is Seeed studio Xiao sense S3 = 15$

[liqijian101]

I did also and cannot duplicate the issue, communication failed but no such error。

I just tested it again, and the program can run normally. It's so weird。Anyway, thank you very much。

That is Seeed studio Xiao sense S3 = 15$。

This is great, but if I design a DIY capable motherboard, the cost is only $7 in China。

That not clear - what the issue ? error ? performances ? crash ? please elaborate

ESP_ERROR_CHECK failed: esp_err_t 0x105 (ESP_ERR_NOT_FOUND) at 0x42084661 file: "./managed_components/espressif__usb_host_cdc_acm/cdc_acm_host.c" line 897 func: cdc_acm_host_close expression: cdc_acm_reset_transfer_endpoint(cdc_dev->dev_hdl, cdc_dev->data.in_xfer)

[liqijian101]

I have found the reason. It's because my 3D printer motherboard has insufficient output power and cannot drive the screen

[luc-github]

I have found the reason. It's because my 3D printer motherboard has insufficient output power and cannot drive the screen

that make sense, on my side I always external power the tft, usb is only for communication

[luc-github]

So do you considere the PR is now Ok and can be merged ?

[liqijian101]

The pr is ok .it can be merged.