Closed BToersche closed 4 years ago
interresting I did not know the M105 R
it is not documented in GCODE list : https://marlinfw.org/docs/gcode/M105.html
same for Probe and Chamber
are these controls compatible in repetier and smoothieware ? I did not see any fw check
Rather than waiting for my probe to arrive, I've decided to test the code by editing the pins in my printer's firmware such that the probe and chamber temps would read a copy of the already installed probes. All works as it should:
In terms of firmware compatibility, I've checked each of the firmwares to see which of the thermistors are supported:
Marlin
print_heater_states
at line 2920 in temperature.cpp)print_heater_states
at line 2950 in temperature.cpp)print_heater_states
at line 2937 in temperature.cpp)Marlin Kimbra
print_heaterstates
at line 3096 in MK_Main.cpp)print_heaterstates
at line 3096 in MK_Main.cpp)print_chamberstate
at line 3140 in MK_Main.cpp)Repetier (Both ArduinoAVR and ArduinoDUE)
printTemperatures
at line 193 in Commands.cpp)printTemperatures
at line 193 in Commands.cpp)printTemperatures
at line 254 in Commands.cpp)(*) Repertier is able to show chamber temperatures, however these are stub temperatures copied from extruder0.
Repetier for Davinci (Both ArduinoAVR and ArduinoDUE)
printTemperatures
at line 155(AVR)/279(DUE) in Commands.cpp)printTemperatures
at line 155(AVR)/279(DUE) in Commands.cpp)printTemperatures
at line 155(AVR)/279(DUE) in Commands.cpp)Grbl
gc_execute_line
at line 245 in gcode.c)gc_execute_line
at line 245 in gcode.c)gc_execute_line
at line 245 in gcode.c)Smoothieware
on_gcode_received
at line 229 in TemperatureControl.ccp)on_gcode_received
at line 229 in TemperatureControl.ccp)on_gcode_received
at line 229 in TemperatureControl.ccp)(*) By default, the configuration files only include hotend and bed temperature_control
, however it seems you can simply add the required temperature_control
modules, since you can change the designator (R
/P
/C
, line 140), the GCode (to M141 for chamber, line 135) and not set a heater_pin for readonly mode (for redundant and probe, line 162). Though, this possibility might not immediately be clear for users.
For Smoothieware it might be a good idea to add some information next to the options, because people might not know the required designator for each of the thermistors. Of course this information is hidden when another firmware is used: Let me know if you agree.
I'll add the required firmware checks to the PR tomorrow or the day after.
No need to add smoothieware information in webUI should be ok to be in wiki
So please hide when not applicable in preferences - UI should follow also there are marlin_embeded which act as marlin and grbl_embeded which act as grbl
I will see how to add these in 3.0 3.0 is more flexible than 2.X- it build UI according the content of M105 answer, and because in 3.0, the poilling command is configurable by user, no need to have new preferences setting to choose M105 vs M105 R
Also looking at UI screenshot - redondant should not have target output if cannot be controled, or I missed something? I guess probe should be same
I've added the required firmware checks for the temperature controls and tested these on my machine. Like stated, my machine runs Marlin, so I can only really test whether or not it works for the Marlin firmware. I did however also test to see if the options would be properly hidden if I removed Marlin from the supported firmwares, which worked correctly.
As for the target temperature values: When a target is set for Heater T0, Marlin will also report this target temperature for the redundant sensor. This makes sense considering the redundant sensor is measuring the same heater as T0: As for the Probe, I intentionally kept the target temperature value in the UI as well because:
Also: I merged the base branch into this branch and rebuild the index.html.gz
files including your changes.
Ok thank you for clarification - I will review on my side and merge it once done
I have added same support in 3.0
@all-contributors please add @BToersche code improvement
@luc-github
I've put up a pull request to add @BToersche! :tada:
Changes in the Temperatures tab. The redundant and probe temperatures do not have controls associated with them, since they cannot be controlled after all. Each of the temperatures have been added to the 2 graphs at the bottom:
Added options for enabling/disabling to the preferences menu (defaults are: "disabled").
Some notes:
print_heater_state
in temperature.cpp at line 2868) to make sure the probe and chamber work properly.