luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC
GNU General Public License v3.0
752 stars 305 forks source link

WebUI - axis movement by cursor keys #164

Closed luc-github closed 2 years ago

luc-github commented 3 years ago

From Grbl_Esp32 created by JensHauser: bdring/Grbl_Esp32#791

Please describe the feature you would like implemented Up/Down and Left/Right cursor keys for x/y axis would be very helpful as a solution for making movements.

What do you need the feature for? I use a laptop with WebUI to move the x/y axis to the right location. Hitting the circle field and in parallel watching the cnc mill is not that easy :-) Taking cursor keys, e.g. in 10mm steps, would be better.

Will this feature appear to a lot of users? I hope so.

luc-github commented 3 years ago

@JensHauser issue has been moved to webUI

luc-github commented 3 years ago

In 3.0 the plan is to use button UI instead of pronterface for Jog: https://github.com/luc-github/ESP3D-WEBUI/issues/144#issuecomment-764845963

Access Key has been discussed here: https://github.com/luc-github/ESP3D-WEBUI/issues/108, but I did not digged in to solve the problem yet

Feel free to join discussion here: https://github.com/luc-github/ESP3D-WEBUI/issues/144

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

luc-github commented 3 years ago

about access-key, this https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey explain that they behave differently according OS and browser and may need several keys at once - which is not really great, so solution does not fit dirrections keys In addition it seems recommendation is actually :

it is generally advised not to use accesskeys for most general-purpose websites and web apps.

So I think I will use onkeydown for up/down/left/right arrows on main container https://www.w3schools.com/jsref/event_onkeydown.asp when jog panel is visible

luc-github commented 2 years ago

POC is now implemented in printer using keyboard eventListener - I meet a problem with removeEventListener that seems not working with preact for some reason, so I have add some hack until fix is found The Printer UI use Pronterface but for keyboard it switch to mobile UI, for not printer UI that do not use pronterface UI (e.g CNC) the UI will stay the same (button style UI) keyboard

luc-github commented 2 years ago

Key mapped helper added image

JensHauser commented 2 years ago

Thank you, Luc. I guess this enhancement will be part of next ESP32/Fluid distro, so I´m curious to make use of it

luc-github commented 2 years ago

@JensHauser for what I can see fluidNC use Mitch fork with cncjs UI which has already this feature if I am not wrong

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.