luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC
GNU General Public License v3.0
752 stars 305 forks source link

[BUG] GRBL V3 does not start #192

Closed Luterocoruna closed 2 years ago

Luterocoruna commented 2 years ago

Describe the bug When you load GRBL webUI it does not start

To Reproduce load index.html.gz created for GRBL and webui does Not start. the start time circle keeps spinning

Expected behavior webui starts

Screenshots If applicable, add screenshots to help explain your problem.

ESP3D Firmware: (please complete the following information)

Target Firmware: (please complete the following information)

Board used (please complete the following information):

Browser used (please complete the following information):

Additional context in the file ESP3D-WEBUI/src/components/settings/webui.js in line 48 --> you use initmachine that function does not exist you call it in line 199 and the webui does not start I think the one that you should call is initDefaultMachineValues so in line 48 you substitute initmachine for initDefaultMachineValues and in line 199 you substitute initmachine for initDefaultMachineValues After those changes the webui for grbl starts then there are other problems but this one is fixed, or so i think

github-actions[bot] commented 2 years ago

Thank your for submiting, please be sure you followed template or your issue may be dismissed.

luc-github commented 2 years ago

the webui 3.0 has no real grbl support yet, only Marlin was done as POC with some part for GRBL but not tested This version of 3,0 was my first project using preact and so it is full of glitches, the rewrite is ongoing but gui is not yet defined https://github.com/luc-github/ESP3D-WEBUI/issues/144 so no webui 3.0 for grbl yet sorry, pls be patient it will be out soon

Luterocoruna commented 2 years ago

Thank you so much for your great work.

luc-github commented 2 years ago

I close issue then, thank you