luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC
GNU General Public License v3.0
747 stars 305 forks source link

[FEATURE REQUEST]Notification panel #226

Closed luc-github closed 2 years ago

luc-github commented 2 years ago

Add notification panel that keep all notifications displayed by toaster error and [ESP600] notifications. allowing to scroll/clear all already displayed notifications

MitchBradley commented 2 years ago

I don't know if this fits into your UI paradigm - but instead of a panel that takes up screen real estate, I would prefer a modal dialog that would float over the top of the UI when you ask for it, then dismiss it when you are done. Notifications like this are not something that you interact with in normal use. I think that panels should be for things that need to stay on the screen during normal use.

luc-github commented 2 years ago

Panels are show/hide anytime and unlike modal dialog they are updated in live This panel is more a log of all notifications in same way the terminal is a log of all commands received, it does need to be opened at start and even no visible if user do not need it. A float modal dialog is modal -> blocking so I do not see the point to be float, additionaly a float dialog is not something easy to handle in mobile view, so instead of creating a new control specificaly for the notification log which will increase code size - using panel API is the solution that fit all needs currently. If in future when UI is done and size is small as expected, we can improve the user experience by adding new kind of control / user flow, it will be definitly done - but right now I prefer to stick to current API implementation if it fit the needs.

luc-github commented 2 years ago

Notifications panel added notifications

it add 69,195 bytes->69,667 bytes = + 472 bytes which is I think not too much

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.