Implement key map overrides for jogging. Prevent key shortcuts from disrupting typing in Text fields (e.g. Terminal Console)

luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC

GNU General Public License v3.0

734 stars 303 forks source link

Implement key map overrides for jogging. Prevent key shortcuts from disrupting typing in Text fields (e.g. Terminal Console) #285

Closed aaronse closed 1 year ago

aaronse commented 1 year ago

See https://github.com/luc-github/ESP3D-WEBUI/pull/284 and https://github.com/luc-github/ESP3D-WEBUI/pull/283 for details

luc-github commented 1 year ago

@aaronse I have implemented support for all keys for 3D Printer jog and created a new input text flag for capture shortkey, so I do not have to generate an array of all possible key mapping , doing that it was trivial to add combination keys support so I did it 😸

So I did not merged your PR yet

Do you want to update your PR to support combination keys? (you can refer to here to do the match ) then I will merge your PR Or I merge your PR first, and I modify your code accordingly by myself

Please let me know

aaronse commented 1 year ago

Nice! Look forward to trying out the changes, am in Seattle time zone so won't be trying until much later today.

Or I merge your PR first, and I modify your code accordingly by myself

Please merge and modify, seems like faster option. Cheers!

luc-github commented 1 year ago

Modifications done - let me know what you think If ok it can be ported to jogCNC / jogPlotter

aaronse commented 1 year ago

Just read the changes, they look good to me. Will pull, build and try out later today. Cheers!