search

luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC
GNU General Public License v3.0
756 stars 305 forks source link

Implement really really basic autocorrect #287

Closed aaronse closed 1 year ago

aaronse commented 1 year ago

Terminal should be smart enough to auto uppercase at least the most common scenarios.

Currently just glorified toUpperCase, but could be extended to much more if/when Users provide feedback on how useful this is to them.

luc-github commented 1 year ago

This request is not new and still not convinced about it :

It is not that simple : some commmand use Password which are case sensitive, some FW like smoothieware use lower case for console commands, so it is lot of specific case that need to be handled

Be predictive of what user want to do is subject to lot of issue question of not handled cases, if printer FW is case sensitive, it is better to be same, no mention that this not affect telnet / serial / websocket input and so there will be no consistency for user

it is better user type right / lear to type right instead of driving him and may be wrongly (Murphy law)

aaronse commented 1 year ago

This request is not new and still not convinced about it :

Agree, it's not new and seems to keep coming up... So there's room to improve User experience.

It is not that simple : some commmand use Password which are case sensitive, some FW like smoothieware use lower case for console commands, so it is lot of specific case that need to be handled

Agree. It's an optional setting, disabled by default. Myself and others at https://forum.v1engineering.com/t/headless-skr-pro-info/34707 will likely use, understanding the limitations. The code plays offensive audible warning if casing is changed, that will help inform and train the User. Arguably a better experience than today where incorrect case results in unexpected behavior that User doesn't understand.

Be predictive of what user want to do is subject to lot of issue question of not handled cases, if printer FW is case sensitive, it is better to be same, no mention that this not affect telnet / serial / websocket input and so there will be no consistency for user

it is better user type right / lear to type right instead of driving him and may be wrongly (Murphy law)

Personally, I think it's better that software help Users achieve their intent/goal. Reduce cognitive load so they can focus on the overall task they're trying to get done.

luc-github commented 1 year ago

As it is the PR won't be merged because it looks more limited user settings for one FW that mess up most of others users /FW because of user cases / firmware not handled as mentionned above : https://github.com/luc-github/ESP3D-WEBUI/pull/287#issuecomment-1368325335 So I close it