Fix number input field currently in focus to not invoke key shortcuts. Also, fix keyshortcut to insensitive...

luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC

GNU General Public License v3.0

734 stars 303 forks source link

Fix number input field currently in focus to not invoke key shortcuts. Also, fix keyshortcut to insensitive... #291

Closed aaronse closed 1 year ago

aaronse commented 1 year ago

Fix number input infocus to not invoke keyshortcut.

Fix keyshortcut code to be insensitive. Reason... Current checked in code is not working for arrow keys. Uncommenting //console.log helped troubleshoot and figure out problem

problem: preferences.json contains "LeftArrow" but index.js uppercases key press, see keyval += e.key.toUpperCase() fix: do insensitive checks, so doesn't matter what's configured.

luc-github commented 1 year ago

@all-contributors please add @aaronse for code improvement

allcontributors[bot] commented 1 year ago

@luc-github

I've put up a pull request to add @aaronse! :tada: