luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC
GNU General Public License v3.0
734 stars 303 forks source link

[BUG]Error message not displayed in Notifications, followup to #290 #299

Closed terjeio closed 1 year ago

terjeio commented 1 year ago

Describe the bug Error message reported when attempt to save setting is not displayed in Notifications as suggested in #290:

BTW What is/where can I find the "toaster" you mentioned in #290?

To Reproduce Steps to reproduce the behavior: Trying to enable soft limits without enabling homing.

Screenshots

image

ESP3D Firmware: (please complete the following information)

Target Firmware: (please complete the following information)

luc-github commented 1 year ago

the toaster appear on top of webpage during 5 seconds

I will try to reproduce issue when back home

luc-github commented 1 year ago

@terjeio my bad - I missed to copy the data content in error message - should be fixed in https://github.com/luc-github/ESP3D-WEBUI/commit/f5275d4b4fc1a5bcfd287b19bdfa9110dbcb0e41

terjeio commented 1 year ago

Thanks, working now!

image

luc-github commented 1 year ago

thank you for the confirmation ^_^

luc-github commented 1 year ago

I close issue then

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.