search

luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC
GNU General Public License v3.0
733 stars 304 forks source link

Jog Rose size #340

Closed Ulisse76 closed 1 year ago

Ulisse76 commented 1 year ago

is it possible to insert a combobox/radiobutton to increase the size of the JogRose by x1 x2 x4 x8 times? TY

github-actions[bot] commented 1 year ago

Thank your for submiting, please be sure you followed template or your issue may be dismissed.

luc-github commented 1 year ago

what do you mean? do you have screenshot?

Ulisse76 commented 1 year ago

I attach the screenshot. compared to the box the "JogRose" has reduced dimensions. it would be nice to have it in a larger (double for example) size for those who use touchscreens

ok

luc-github commented 1 year ago

the area you mention is reserved to macro buttons in 2.x and UI is not maid to be dynamic enough to be resized, so no it won't happen sorry

but in webui 3.X the UI is the following : image

and it has now a mobile view for phone/tablet image

So you should not have issue anymore

Ulisse76 commented 1 year ago

I found a solution that may be useful to someone. I zoomed in 1.4 times like this:

<svg width="310" height="400" xmlns="http://www.w3.org/2000/svg" version="1.1" style="transform: scale(1.4); transform-origin: top left;">

in this way I am happy and I solved it on the fly

DivingDuck commented 1 year ago

Hi there, @luc-github , wouldn't it be better to increase the svg width so that is fits a bit better in the jog container? The default value is quite small compared to the jog panel width and this is why it looks a little bit lost in a browser compared to other panels like for Macros, Camera or Charts.

svg width=250 (original) ESP3DJogControl1

svg width=340 (modified) ESP3DJogControl2

That way it works as well with the zoom function in a browser and still usable with 50% zoom factor in a browser.

File jog.js, line 502: width="250px" to width="340px" or what ever fit better (maybe something between 300 and 340).

luc-github commented 1 year ago

indeed this size come from original width panel and I forget to adjust following new panel width, I have added a css to auto adjust width in case we change panel min width again which is currently 330px and removed the hard coded width in svg

image

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.