[DRAFT] Use dosnames in `M23` commands for Marlin

luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC

GNU General Public License v3.0

733 stars 304 forks source link

[DRAFT] Use dosnames in `M23` commands for Marlin #344

Closed eduard-sukharev closed 1 year ago

eduard-sukharev commented 1 year ago

Marlin requires short 8.3 DOS names for all file handling commands.

When Marlin uses MKS Serial protocol files are always listed with dosnames only, even with M20 L command. In order to support displaying long filenames and be able to print them ESP3D-WEBUI has to use both reported filenames: short one for issuing Print and Delete commands, and long ones, when available, to nicely display in file list panel.

This is draft PR that has not yet been tested.

luc-github commented 1 year ago

Marlin merged this PR https://github.com/MarlinFirmware/Marlin/pull/23526 for M23 long name support

luc-github commented 1 year ago

and I tested it was working https://github.com/luc-github/ESP3D-WEBUI/issues/221#issuecomment-1228460590

I wont recommend to workaround a broken feature , better fix the feature in Marlin