search

luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC
GNU General Public License v3.0
756 stars 305 forks source link

Add Ok filter to improve webui response parsing (And Play button [ESP700] implementation) #346

Closed jamespearson04 closed 1 year ago

jamespearson04 commented 1 year ago

Does it not use the commands from SD-source.js in those circumstances? If not, why are there seperate files for SD-source.js and DIRECTSD-source.js (Only have a little experience with js, so forgive me if I'm missing something)

luc-github commented 1 year ago

In shared mode it is the printer that directly print not ESP3D, ESP3D in that mode only upload the file to shared SD, and shared mode is used by esp8266 hardware which wont't be able to stream for esp32 it is used by esp3dlib /Marlin and it is Marlin that print not ESP3D

jamespearson04 commented 1 year ago

I see, "shared" mode also uses DIRECTSD, makes sense. I'll add in the if statement

luc-github commented 1 year ago

Yes webUI cover a lot of configurations - it is why I had to rewrite it - to make it more flexible

luc-github commented 1 year ago

@jamespearson04 is this PR still valid ? WebUI will be updated due to coming change in gcode streaming service and some part have been already integrated

jamespearson04 commented 1 year ago

I'll take a look through, it's been a little while so I'll see if there's anything useful left

luc-github commented 1 year ago

@all-contributors please add @jamespearson04 for code update and idea

allcontributors[bot] commented 1 year ago

@luc-github

I've put up a pull request to add @jamespearson04! :tada: