search

luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC
GNU General Public License v3.0
733 stars 304 forks source link

[FEATURE REQUEST]Improve usage of ISO-8601 date format #369

Closed luc-github closed 7 months ago

luc-github commented 9 months ago

Linked to https://github.com/luc-github/ESP3D/issues/935 1 - when setting date by [ESP800] command, use +/-XX:XX additional info (optionnally ) to set the time zone also 2 - add optionnal parameter in post which would be the date/time in same format (2023-10-10T11:08:47+08:00) and the last modified date/time of the file using file.lastModified; API

luc-github commented 8 months ago

The time zone is an optional parameter in web ui now tz=+/-HH:MM The SD is fat32 which store only local time not UTC so current format is ok (2023-10-10 11:08:47) That said I will add support of 2023-10-10T11:08:47+08:00 and 2023-10-10T11:08:47.000+08:00 format in webUI /files and /sdfiles responses JSON, to make porting easier on coming FW

The upload will also have a last modification date as post parameter which could be used to update file timestamp on ESP that does not have time sync enabled

luc-github commented 8 months ago

Additionnaly there is no DST support for the moment - because it need to access to a database that won't fit to flash.

One solution would be to detect time difference between browser time supplied by ESP800 and time set and if time is different by 1h propose to user to update time on esp board, it is one possible solution =>TBD

Any suggestion // other idea is welcome

luc-github commented 7 months ago

done I think

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.