search

luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC
GNU General Public License v3.0
756 stars 305 forks source link

[FEATURE REQUEST] Sort Gcode files by "date modified" or leave them unsorted as provided by host/TFT #386

Closed rondlh closed 3 months ago

rondlh commented 5 months ago

Is your feature request related to a problem? Please describe. Typically I want to print the last file I copied to the USB flash drive in my TFT display when I issue a M20 U: (list USB files). Unfortunate ESP3D sorts the files alphabetically, so I have to dig around to find the file I want to print.

Describe the solution you'd like Add an option to 1. sort the files alphabetically, or 2. don't sort them because the TFT handles this already.

Describe alternatives you've considered This can also be hard coded, then leave it up to Marlin or in my case the TFT to provide the files in the required order (which can be configured).

Additional context I use ESP3D V3.0, which I can recommend over V2.1

github-actions[bot] commented 5 months ago

Thank your for submiting, please be sure you followed template or your issue may be dismissed.

kleffa commented 5 months ago

https://marlinfw.org/docs/gcode/M020.html well only in latest Marlin are avaible the time stamp for M20 , so I think they can be sort by date or name

rondlh commented 4 months ago

https://marlinfw.org/docs/gcode/M020.html well only in latest Marlin are avaible the time stamp for M20 , so I think they can be sort by date or name

The case you describe is different from my case. I would like to have the option to not sort the files alphabetically, but just display them in the order they are provided. This is because I use a TFT with SD/USB reader that gives me various options to sort the files. But then ESP3D sorts the files again, which makes the TFT sorting useless.

kleffa commented 4 months ago

ESP3D didn't sort files, they are just in order provided, which is a Marlin feature, maybe you can try make a better UI to make god lists or change options in marlin to sort them by date

rondlh commented 4 months ago

ESP3D sorts the files in src\components\Helpers\filters.js This has nothing to do with Marlin, because the M20 response is provided by the TFT, not Marlin.

luc-github commented 3 months ago

Fixed by https://github.com/luc-github/ESP3D-WEBUI/commit/423dbae646ada07fe3088f0e66b46ab671b21491

github-actions[bot] commented 2 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.