search

luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC
GNU General Public License v3.0
733 stars 304 forks source link

Add support for FluidNC #389

Closed michmela44 closed 2 months ago

michmela44 commented 2 months ago

After working with the FluidNC team on it, FluidNC now has built in support for ESP3D-WebUI V3 as an unofficial option since version 3.7.14.

This PR adds a support for FluidNC into the ESP3D WebUI as well

luc-github commented 2 months ago

Hmmm why this PR ? as wrote before Bart did not wanted fluidnc be supported by me and webui 3.0

they prefere to maintain their own fork per my understanding

michmela44 commented 2 months ago

My understanding was that they did not want you to bother having to make the changes and maintain support for version 2.0 of the WebUI, as to not pull your focus away from your ongoing version 3.0 efforts.

I believe that was the reason for maintaining their own fork for v2 of the WebUI.

I can check with them again, but I have not seen anything from them since I have been involved that would suggest they were against being supported by WebUI 3.0 officially.

luc-github commented 2 months ago

No, that was not the message I got, you are wrong, sorry. There was no such discussion with me. I respect choice Bart made ,and I do not plan to go against the decision made.

MitchBradley commented 2 months ago

Hi luc, Mitch Bradley here. I'm a core FluidNC developer and the maintainer of the WebUI 2 fork and the FluidNC protocol support for both v2 and v3. I'm sorry for the miscommunication.

@michmela44 has the right understanding. Bart and I have been following v3 with great interest. At the time we decided to maintain our own fork, we always intended it to be a temporary bridge to v3. We could see that you were doing great things with v3 but it wasn't quite ready yet. We wanted to let you focus and complete the impressive work that you have done. Now that v3 is solid, we would like to migrate to it. We added v3 protocol support to FluidNC several releases ago, with v2 interoperability so users can choose when to migrate. Users have been testing it based on the work in this PR with good results. People like v3 a lot. It would be great if this PR could be merged.

There was a time when we were not yet ready to upstream FluidNC support because we had not yet worked out all the details of v2 interoperability . We have since resolved those issues and our recent releases are working well for both v2 and v3 users. Could it be that the message "not now" was miscommunicated as "not ever"? If so, please accept our apologies for being unclear.

If there are technical problems with this PR, we would be happy to address them. I think that the FluidNC side of the protocol is in reasonable shape, but if there are problems with that I will fix them.

I can assure you that Bart and I are in full agreement on this matter.

luc-github commented 2 months ago

@MitchBradley please, Bart asked me to not work on FluidNC Webui in March 2021, and just after (less than one week) released a forked WebUI, and since never communicate with me, it is not what I would call a miscommunication, I was part of initial dev team with Bart and left it to let you space, so your above description is little bit offending.

Please do not rewrite the past, I was there and so do you, and your attitude was not the one you describe, Bart as owner of grbl_esp32 and fluidnc project made his choice and I respect it.

Also the wiki is pretty clear fluidnc fluidnc1

I am not here to do any drama, I just respect decision made by Bart and I see no reason today to go against it.

I also do not see really any reason to handle a code for a project that do not want to, Bart never mentionned he changed his mind to me so far in 3 years that is why this PR cannot be merged.