[BUG] BTT TFT SD/USB listing fails because of M21

[rondlh]

Describe the bug Trying to list the files on the SD/USB port of an attached BTT TFT35 V3.0 fails. An errors is reported: "Parse response error, format is incorrect". Changing the TFT type in the Settings/Files panel does not solve this issue. (Removing the M21 solves the issue for me). I believe that at least for the BTT Touchscreen firmware the M21 is not needed.

To Reproduce Steps to reproduce the behavior:

1. Try to list the files of an attached BTT TFT SD/USB card in the dashboards This fails with:

   M21
   M20 SD:/
   echo:No SD card
   Media Init Fail
   Begin file list
   ALIGN_XY.GCODE
   End file list
   ok

OR:

M21
M20 U:/
echo:No SD card
Media Init Fail
Begin file list
IDEX_COIN.gcode
End file list
ok

As can be seen, an M21(init media) is send before the M20(list media). If I remove the M21 then things work for me.

Expected behavior Works like before (like a few months ago).

ESP3D Firmware: (please complete the following information)

• Version: 3.0.0-a234
• Web UI Version: 3.0.0-a64.M2.1]

Target Firmware: (please complete the following information)

• Name: Marlin
• Version: Latest bugfix

Board used (please complete the following information):

• MCU: ESP32]
• Name: Development module
• Flash size: 4M

Browser used (please complete the following information):

• Name: Chrome
• Version: 126
• Operating system: Windows 10

ADDITIONAL COMMENT: In the Settings/Files panel the "TFT" brand can be selected (None/Bigtreetech/Makerbase). This is a bit misleading because I have Makerbase TFTs that run the BTT touchscreen firmware, and thus should be treated as a Bigtreetech TFT. So perhaps a better title would be "TFT Firmware".

[luc-github]

Yes put M21 in TFT commands may lead to failure if no SD in main board SD card reader - I guess I did the test with SD in reader and missed the issue - thank you I have updated the default commands in settings for BTT SD and USB : I have rebuild the package but if the commands are already saved in preferences.json , need to update the commands manually in settings/interface, or delete preferences.json and reload webUI

[luc-github]

I close issue as fixed - thank you for pointing out

[luc-github]

About title I try to make it as simple as possible people who flash MKS TFT with BTT FW compatible should understand what they are doing, and they are not a majority of user (I did it too before)

FYI I already got comment like: what means: Update FW? and after update it : what means Update Firmware ? such thing is never ending unfortunatly so Use TFT Firmware may confuse them ...

[rondlh]

All clear, thanks again for the quick response and support!

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.