luc-github / ESP3D-WEBUI

A Web UI for ESP8266 or ESP32 based boards connected to 3D printers / CNC
GNU General Public License v3.0
762 stars 305 forks source link

SD printing marlin firmware (fix) #59

Closed lucmoda closed 5 years ago

lucmoda commented 5 years ago

Issue fix - SD card print with Marlin firmware.

luc-github commented 5 years ago

What is that ? Marlin give file list in upper case and printing is just fine using name provided by Marlin, Marlin 1.1.9 and 2.0 works like this, tested and verified Why to turn filename to lower case when marlin give upper case ? looks like FW issue

luc-github commented 5 years ago

I am guessing you use prusa FW as this was raised before : https://github.com/luc-github/ESP3D/issues/273

luc-github commented 5 years ago

additionnally this change will affect others FW smoothieware / repetier / Marlin / MarlinKimbra which have no issue - so it can not be applied sorry

luc-github commented 5 years ago

Please confirm the Firmware version and base you are using

lucmoda commented 5 years ago

I found the problem about the Marlin and SD printing: Tested (with upper case) Marlin 1.0.2 not work, with Marlin >=1.1.9 work fine.

luc-github commented 5 years ago

I close this PR then as no need this sd fix

luc-github commented 5 years ago

@lucmoda About Brasialian Portuguese, to push new PR you need to do it without the SD fix or git will try to push it also