search

luc-github / ESP3D

FW for ESP8266/ESP8285/ESP32 used with 3D printer
GNU General Public License v3.0
1.73k stars 465 forks source link

[FEATURE REQUEST] Add BME280/BMP280 support #464

Closed nanogennari closed 4 years ago

nanogennari commented 4 years ago

BME280 and BMP280 sensors are much more reliable than DHT11 and DHT22, it would be nice to have support.

github-actions[bot] commented 4 years ago

Thank your for submiting, please be sure you followed template or your issue may be dismissed.

luc-github commented 4 years ago

do you have a recommended library for esp32 and esp8266?

nanogennari commented 4 years ago

The library Adafruit_BME280 (https://github.com/adafruit/Adafruit_BME280_Library) is in the Arduino repositories and it is quite simple to implement.

luc-github commented 4 years ago

need also sensor library from adafruit...

From: Nano Gennari notifications@github.com Sent: Sunday, May 17, 2020 6:39:54 AM To: luc-github/ESP3D ESP3D@noreply.github.com Cc: Luc luc.lebosse@tech-hunters.com; Comment comment@noreply.github.com Subject: Re: [luc-github/ESP3D] [FEATURE REQUEST] Add BME280/BMP280 support (#464)

The library Adafruit_BME280 (https://github.com/adafruit/Adafruit_BME280_Library) is in the Arduino repositories and it is quite simple to implement.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/luc-github/ESP3D/issues/464#issuecomment-629742205, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACDJ6GDZTPIOUEPCCK2KHPDRR5TBVANCNFSM4NDD4NTA.

luc-github commented 4 years ago

this one looks more monolitic : https://github.com/MartinL1/BMP280_DEV

luc-github commented 4 years ago

I need to think how to do more generic sensor support/interface, there is also https://github.com/luc-github/ESP3D/issues/432 Current sensor support is focused on DHT but would be better to make more generic for communication with webUI - As sensor support is not yet done in webUi 3.0 there is some time to think - TBD

luc-github commented 4 years ago

Also I do not have any BMP280 device for the moment...

nanogennari commented 4 years ago

If you need i can test and debug any code for the BME/BMP sensor. The idea of generic sensor support is nice, i even tried to alter your code to add it myself but like you said the code is too focused on the DHT, anything i could do would be too jerryriged in place.

this one looks more monolitic : https://github.com/MartinL1/BMP280_DEV

This library looks nice also, and it has some extra features. Although i use BMEs frequently, I'm not very intimate with programming for it, normally i use it with tasmota and extract the data via MQTT (mqtt support would also be nice, something like a simple json telemetry with printer and sensor status).

luc-github commented 4 years ago

I have ordered one BMP280 and one BME280 3.3V and will got them next week, I will prepare the code to support them and make output more generic for WebUI

nanogennari commented 4 years ago

Nice, looking forward to it...

luc-github commented 4 years ago

@nanogennari what sensor do you have BMP or BME ? It seems I only got BMP sensors which do not have the humidity support

luc-github commented 4 years ago

Implemented in FW - now I will update webUI to display it in notification area

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.