search

luc-github / ESP3D

FW for ESP8266/ESP8285/ESP32 used with 3D printer
GNU General Public License v3.0
1.73k stars 465 forks source link

Allow to disable data port #78

Closed luc-github closed 8 years ago

luc-github commented 8 years ago

add a compilation directive to add authentication or disable fully the data commands use same login password as web

luc-github commented 8 years ago

for safety purpose

luc-github commented 8 years ago

Disable feature is now possible https://github.com/luc-github/ESP8266/commit/e4af1950eb5c1efbd31f6e83b6f809e66f23df8f For authentication - implementation problem come from host - repetier do not have authentication protocol - just raw data One solution is to open a telnet session using same port, and if authentication succeed, IP is granted until last packet from this IP is delayed of certain amount of time - but not really smooth

luc-github commented 8 years ago

Need to find a proper approach - but now I am dry on it

luc-github commented 8 years ago

as there is no software using the authenticate feature for data port - I guess we are good and no need Authentication of data port is not necessary but may go with websocket so as feature can be disabled - lets close issue

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.