search

luc-github / ESP3D

FW for ESP8266/ESP8285/ESP32 used with 3D printer
GNU General Public License v3.0
1.71k stars 466 forks source link

Support for M28/M29 commands #96

Closed luc-github closed 8 years ago

luc-github commented 8 years ago

ESP has a HW buffer of 128 bytes when post buffer is 2048- so just doing a pass through crash the board due to overload buffer on repetier and smoothie. also transfert between smoothie / repetier and marlin are different repetier / smoothie interprete each line and ask to resend or generate error if line is not a proper GCODE line when marlin (at least old version I have) do not care and write as it is.

Of course ack msg / error msg are different for each fw :smile:

I got some issue with Serial.write("M117 test\n") when Serial.println("M117 test") is fine, so could be a problem for binary GCODE upload

also using web UI with file upload do not give the time of processing - so no information how long it will take to finish

so actions to be done 1 - need to be sure no command is over 128 bytes to avoid over load when using Repetier host / pronterface and wait for acknoledgment 2 - review the Serial.write command to ensure it is properly working [EDIT] is buffer is under 128 bytes, write command is OK 3 - need to develop a GCODE uploader to send file with some informative progress bar instead of on going and done

Now I remember why I postponed this feature .....

luc-github commented 8 years ago

implemented with https://github.com/luc-github/ESP3D/commit/6d73f3a9f2cba7344a3dca4941962694e1deb20c

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.