search

luc-github / ESP3D

FW for ESP8266/ESP8285/ESP32 used with 3D printer
GNU General Public License v3.0
1.78k stars 466 forks source link

[BUG]Pull request #960 generate a compiling error with activated CAMERA_DEVICE = CAMERA_MODEL_AI_THINKER #963

Closed DivingDuck closed 1 year ago

DivingDuck commented 1 year ago

Describe the bug

Last code update from pull request #960 generates a compiler error when a camera modul is activated (in my case CAMERA_DEVICE = CAMERA_MODEL_AI_THINKER)

Error:

Involved files: configuration.h, line 493 camera.cpp, line 81

**'HTTP_Server' has not been declared
name followed by '::' must be a class or namespace name**

To Reproduce

Activate CAMERA_DEVICE = CAMERA_MODEL_AI_THINKER in configuration.h, line 493

Expected behavior

n/a, compiling w/o error

Screenshots

ESP3D_issue#963

ESP3D Firmware:

Target Firmware:

Board used (please complete the following information):

Additional context

Up to last update ESP3D was compiling fine. Turning camera.cpp, line 81 into a comment line will compile the firmware. After uploading the new firmware I recognize in -->Settings --> Features a error message parsing data error, data are incorrect

Attachment:

ESP3D-Issue#963.zip

Edit: forgot attachment...

github-actions[bot] commented 1 year ago

Thank your for submiting, please be sure you followed template or your issue may be dismissed. if you deleted the template it is here

luc-github commented 1 year ago

Indeed this case did not go thrue the CI test and I forget to add the corresponding header, thank you for raising the issue - it is now fixed https://github.com/luc-github/ESP3D/commit/265e0e60a2ebb3ff1883c898de83210027f4cbf1

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.