search

luc-github / ESP3D

FW for ESP8266/ESP8285/ESP32 used with 3D printer
GNU General Public License v3.0
1.74k stars 465 forks source link

ESP214/ESP212 and hooks #999

Closed luc-github closed 7 months ago

rondlh commented 7 months ago

[ESP212] seems to work as expected when I define the IP and DATETIME hooks in the configuration. This is a very useful command, which gives great flexibility to ESP3D, great job!

Also sending the [ESP212] commands via the serial port with %ESP_IP% and %ESP_DATETIME% works as expected.

There seem to be some dependencies that are not directly obvious: ESP_GOT_IP_HOOK requires GCODE_HOST_FEATURE ESP_GOT_DATE_TIME_HOOK requires TIMESTAMP_FEATURE and GCODE_HOST_FEATURE

Perhaps some comments could clarify this, or it could be done automatically.

I didn't try [ESP214] because I don't have any ESPs with a display.

luc-github commented 7 months ago

There seem to be some dependencies that are not directly obvious: ESP_GOT_IP_HOOK requires GCODE_HOST_FEATURE ESP_GOT_DATE_TIME_HOOK requires TIMESTAMP_FEATURE and GCODE_HOST_FEATURE Perhaps some comments could clarify this, or it could be done automatically.

I have added some sanity check so now it is handled

luc-github commented 7 months ago

Note: Now I need to update esp3d.io for ESP212 and the ESP3D-Configurator for the new hooks and new sanity checks

EDIT: Done for both: https://esp3d.io/esp3d/v3.x/documentation/commands/esp212/index.html image