luc-github / ESP3DLib

ESP3D library for Marlin and ESP32 boards
GNU General Public License v3.0
97 stars 32 forks source link

[INVALID]<Failed Compile using Platform IO> with BugFix #29

Closed agoy507 closed 3 years ago

agoy507 commented 3 years ago

Describe the bug error compile. Compiling .pio\build\esp32\lib3f5\ESP3DLib\web_server.cpp.o .pio/libdeps/esp32/ESP3DLib/src/sd_ESP32.cpp: In member function 'bool ESP_SD::openDir(String)': .pio/libdeps/esp32/ESP3DLib/src/sd_ESP32.cpp:324:32: error: 'class CardReader' has no member named 'getSd2Card' if (!sd_volume.init(&(card.getSd2Card()))) { ^ Compiling .pio\build\esp32\lib3f5\ESP3DLib\wificonfig.cpp.o At global scope: cc1plus.exe: warning: unrecognized command line option '-Wno-register' *** [.pio\build\esp32\lib3f5\ESP3DLib\sd_ESP32.cpp.o] Error 1.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots image Terminal Message.txt my configuration file Marlin-bugfix-2.0.x.zip Version image

Marlin Firmware:

ESP3DLib :

Board used (please complete the following information):

Additional context wiring board https://github.com/felixstorm/Creality_Ender_3_ESP32_Board

luc-github commented 3 years ago

did you tested with 2.7.2 as mentioned in readme ?

agoy507 commented 3 years ago

not yet. But I Was enable this feature followed in readme. so i attach file configuration. please tested too, and CMIIW.

luc-github commented 3 years ago

2.7.2 is ok image

agoy507 commented 3 years ago

Can you try test with marlin bugfix lastest version ? cause i try 2.7.2 from felixstorm https://github.com/felixstorm/Marlin/tree/Felix_Ender3_ESP32_2.0.x has bug when homing, x axis wrong direction. i want to try bugfix. but error to compile. Thanks in Advance

luc-github commented 3 years ago

Marlin always break everything - and do not care backward compatibility - I will work on next release only - I have no bandwidth to test every change in Marlin and try to fix something that may be broken few commits later Sorry You are free to see what is wrong and push PR but in that case it may not work with 2.7.2

agoy507 commented 3 years ago

ok. i will wait next release with your lib compability. thanks for your contribute.

luc-github commented 3 years ago

if homing in wrong direction it is just a Marlin setting - check the home direction setting, it is not related to Marlin version

agoy507 commented 3 years ago

OK. thanks for advice. i will check again marlin config. i think on bugfix marlin was fix my problem. cause the day before yesterday i was report this issue.

luc-github commented 3 years ago

@agoy507 motor direction and homing direction can be changed in Marlin FW that is for sure if it is homing and moving which are up side down, it can also be changed also by just fliping the motor connector on board if it is possible but do it only when power off or you may damage step driver

and for what it worst the change that generate your issue just happened few hours ago actually : https://github.com/MarlinFirmware/Marlin/commit/138340ee99a852bc116e2a436932bed074624fde But I will only fix it when next release is out if I do now master will be incompatible with current 2.7.2 so need to wait as I do not want to maintain several branch and may be as mentioned code may change again before next release