luc-github / ESP3DLib

ESP3D library for Marlin and ESP32 boards
GNU General Public License v3.0
99 stars 32 forks source link

[BUG]failed compilation on ESP401.cpp #46

Closed nikybiasion closed 2 years ago

nikybiasion commented 2 years ago

Describe the bug Compilation fail with error: .pio/libdeps/mks_tinybee/ESP3DLib/src/core/espcmd/ESP401.cpp: In member function 'bool Commands::ESP401(const char, level_authenticate_type, ESP3DOutput)': .pio/libdeps/mks_tinybee/ESP3DLib/src/core/espcmd/ESP401.cpp:89:34: error: ambiguous overload for 'operator=' (operand types are 'String' and 'bool') response = false; ^

To Reproduce Steps to reproduce the behavior:

  1. pio build

Marlin Firmware:

ESP3DLib :

github-actions[bot] commented 2 years ago

Thank your for submiting, please be sure you followed template or your issue may be dismissed.

luc-github commented 2 years ago

Are you sure you are using latest version ? - you may need to do a clear all in platformio/vscode to update latest ESP3DLib code This issue has been fixed 3months ago : image

And I have just tested compilation pass with AUTHENTICATION_FEATURE image

Be aware if you update code now you will get several updates and some need also the webUI to be updated, so you will have to update the webUI V3 also

luc-github commented 2 years ago

@nikybiasion let me know if a clear all - fix your issue , so this ticket can be closed

nikybiasion commented 2 years ago

ok, i've tried to build mks original firmware with esp3dlib3.0, but it fail. With your Marlin branch everything works fine

luc-github commented 2 years ago

yes Marlin need several changes, not yet implemented

luc-github commented 2 years ago

I close issue then