luc-github / Repetier-Firmware-4-Davinci

Repetier-Firmware-0.92 based for DaVinci printer (Beta - so far so good)
GNU General Public License v3.0
194 stars 98 forks source link

Non UTF-8 characters in source code #370

Closed JacobChrist closed 3 years ago

JacobChrist commented 3 years ago

Describe the bug Non UTF-8 characters in source code.

To Reproduce Opening the project several error messages like the following appeared:

"uimenu.h" contains unrecognized characters. If this code was created with an older version of Arduino, you may need to use Tools -> Fix Encoding & Reload to update the sketch to use UTF-8 encoding. If not, you may need to delete the bad characters to get rid of this warning.

Following the procedure to Tools -> Fix Encoding & Reload did not resolve the issue.

The code still complies, and this may not be an issue, but its scary because I don't want to brick my working printer.

Expected behavior No errors upon opening the project.

PC (please complete the following information): Windows 10 Arduino IDE 1.8.13 (opps, had .18 in error) Arduino SAM Boards (32-bits ARM Cortex-M3): 1.6.8

**Printer Duo 2.0

Firmware (please complete the following information):

JacobChrist commented 3 years ago

I tried to copy and past "uimenu.h" code into Notepad++ and convert to UTF-8 then delete and copy back to Arduino IDE, save the file and reopen the project and could not resolve this issue.

luc-github commented 3 years ago

the readme mention the arduino version to use, did you read it ?

luc-github commented 3 years ago

anyway you may workaround by disabling Japanese in configuration.h

#define LANGUAGE_JP_ACTIVE 0 // Japanese

JacobChrist commented 3 years ago

the readme mention the arduino version to use, did you read it ?

Fair enough. I didn't use the same IDE, but it is a 1.8.x flavor and figured it would be okay. The firmware compiles and loads onto my printer just fine. Just wanted to log the issue.

luc-github commented 3 years ago

I do not reproduce issue and I have tested the latest which is 1.8.13 , my windows support asian chars, so disabling japanese should remove the problem on your side,