luc-nham / lunar-calendar

PHP Lunar Calendar
MIT License
6 stars 1 forks source link

Serious logic error when converting Jdn to Lunar new moon phase #52

Closed luc-nham closed 1 month ago

luc-nham commented 1 month ago

Describe Because in different time zones (locations), the day distance between two lunar cycles is not equal, so the lunar date format will not be the same. For example, between 2 new moon points at the times 2023-12-01 and 2024-0101 Lunar calendar, If the time zone is UTC+7, the difference (calculated at midnight of the two new moons) is 30 days, while if the location is UTC+0 time zone it will be 29 days. For that reason, lunar date formats between time zones will not be able to reference each other.

luc-nham commented 1 month ago

53 fixed