luc-tielen / lua-quickcheck

Property based testing in Lua, inspired by the original QuickCheck.
MIT License
37 stars 1 forks source link

README: describe how to use with external runners and builtin generators #30

Closed ligurio closed 3 years ago

ligurio commented 3 years ago
ligurio commented 3 years ago

Left some minor suggestions, looks good for the rest.

Thanks for suggestions! Everything committed, squashed (also I have added Co-authored-by to mark you as co-author) and force-pushed. Seems change with descriptions for generators requires review too - I'm stuck with description for some of them.

ligurio commented 3 years ago

Unfortunately CI is broken, sorry for that. I'll fix it in a separate commit in the same PR (if you have no objections). right now it can start, but:

luc-tielen commented 3 years ago

@ligurio Yeah, it never is that easy to switch over CI.. I'd look into the segfault first. If we can't fix that; we might have to go back to old way of CI? :thinking:

ligurio commented 3 years ago

Yeah, it never is that easy to switch over CI.. I'd look into the segfault first. If we can't fix that; we might have to go back to old way of CI?

I suspect the root cause is not in CI itself but in actions described by me. CI workflow runs on Ubuntu 20.04, I have the same OS on my laptop and everything works fine there. I'll try to investigate problem more and try to fix it.

ligurio commented 3 years ago

I have found a ticket about random luajit segfaults on running busted and also related conversation in luajit mailing list. Someone suggested a solution with small Lua snippet. I have applied it to lua-quickcheck and now CI is red but due to failed steps with upload code coverage data to coveralls service. I suspect lua-coveralls requires environment variable with coveralls token (see https://github.com/moteus/luacov-coveralls).

For me this solution looks like a dirty hack but I don't know better solution.

luc-tielen commented 3 years ago

@ligurio maybe we should split this PR into multiple parts? Just README docs in this 1, fixing CI in another? CI is broken anyway, so I will merge in when docs are updated.

ligurio commented 3 years ago

Agree. I have failed to fix CI quickly so it's better to split PRs. I'll do.

ligurio commented 3 years ago

@luc-tielen done