search

luca-fiorito-11 / sandy

Sampling nuclear data and uncertainty
MIT License
48 stars 28 forks source link

Add fstart argument to write_line #304

Closed janmalec closed 7 months ago

janmalec commented 8 months ago

It is needed to control how the pendf files are put together. Just like fend, which is already implemented.

luca-fiorito-11 commented 8 months ago

It makes sense. However, any addition to the code requires its own test in the docstring. Can you add it? Also, FEND is ENDF6 nomenclature. Can you check if fstart is part of the default nomenclature? If no indication is given in the endf6 manual, then we can accept fstart

janmalec commented 7 months ago

I changed FSTART to TPID, which is ENDF6 nomenclature and added docstring tests.

luca-fiorito-11 commented 7 months ago

You submitted two items to the same PR. Can you submit two PRs instead?

luca-fiorito-11 commented 7 months ago

@janmalec , the test failed. Can you check it?