Add groundingdino&segment-anything, Edit LightningApp import type - Githubissues

luca-medeiros / lang-segment-anything

SAM with text prompt

Apache License 2.0

1.53k stars 167 forks source link

Add groundingdino&segment-anything, Edit LightningApp import type #46

Closed riverallzero closed 8 months ago

riverallzero commented 8 months ago

Describe your changes and approach used

for Issue #38 include folder of groundingdino and segment_anything, so remove that line in environment.yml segment-anything==1.0 , groundingdino==0.1.0
for Issue #39 change import lightning as L into from lightning.app import LightningApp

Fixes #38, fixes #39

Checklist before requesting a review

[X] I have performed a self-review of my code.
[X] I have performed linting on my code.
[X] I have linked the related issue.
[X] The code is documented accordingly.
[X] If it is a core feature, I have added thorough tests.

luca-medeiros commented 8 months ago

Hi @riverallzero! Appreciate the PR :) While it is a working solution, I dont think it will be a good idea to just clone both the repos inside lang-sam (heavy, clunky and somehow misleading of what this project is about). Maybe adding a Dockerfile with the working env will help people even more.