search

luca-moser / iris-cache

Caching middleware for the iris web framework.
4 stars 1 forks source link

content-type comparison is failing #2

Open dh-harald opened 6 years ago

dh-harald commented 6 years ago

Hi,

In my case https://github.com/luca-moser/iris-cache/blob/master/cache.go#L119 failed, because my Content-type contains my encoding: Content-Type: text/html; charset=UTF-8 Therefore I can't use your provided values for content type (cache.ContentTypeHTML/cache.ContentTypeJSON)

Could you fix it somehow? For example trim the variable after ;. It's not a big deal, but it could be better with a fix.

luca-moser commented 6 years ago

The ContentType constants are merely the same values as used by iris (iris repo link).

With the Config struct, you are able to set a custom ContentType which should be cached (link).

So in your case supplying a Config to NewCacheHF or NewCache with a custom ContentType of "text/html; charset=UTF-8" should fix your issue.

I think it's faster when the user of the middleware supplies his/her used content types, since otherwise the middleware would have to do trimming and whatnot.

dh-harald commented 6 years ago

I know, I'm already using that method, you suggested... (that was my workaround) I've opened this ticket, because based on the documentation, the middleware couldn't working in special circumstances (eg. it's not caching anything). Just because of nature of Content-Type header, you could easily trim it after ;, and the content type values could work afterwards...