search

luca-piccioni / OpenGL.Net

Modern OpenGL bindings for C#.
MIT License
567 stars 107 forks source link

Gl.ShaderBinary causes infinite recursion #136

Closed GiantBlargg closed 5 years ago

GiantBlargg commented 5 years ago

https://github.com/luca-piccioni/OpenGL.Net/blob/75f50d6a21bf3d506c7b6fb7702dbdfd2b54791d/OpenGL.Net/Gl.VERSION_4_1.cs#L519 calls itself, perhaps it should call the other function of the same name: https://github.com/luca-piccioni/OpenGL.Net/blob/75f50d6a21bf3d506c7b6fb7702dbdfd2b54791d/OpenGL.Net/Gl.VERSION_4_1.cs#L549

luca-piccioni commented 5 years ago

Thank you for finding this, Probably there are others. I won't apply your pull request, because the source code is automatically generated, and the culprit must be found in the source code generator.

GiantBlargg commented 5 years ago

Thanks for the quick response.

I like the added convenience that my solution has of not having to specify the count, would it be possible to add a function with the signature ShaderBinary(uint[] shaders, int binaryformat, object binary, int length)