Fix #109, Fix #107 - Githubissues

lucaargolo / fabric-seasons

A simple mod for Minecraft that adds seasons to the game, changing biomes as you play.

Mozilla Public License 2.0

64 stars 47 forks source link

Fix #109, Fix #107 #119

Closed sisby-folk closed 1 year ago

sisby-folk commented 1 year ago

Adds fallback-registered seasonal ice and snow blocks, that replace themselves with vanilla variants via random tick (Fixes #109)
Makes the .minecraft/data directory if it doesn't exist (Fixes #107)

Basically just pulled everything from the patched version of extras to make an upgrade-safe version of seasons.

I'll be using this as a custom build for a while, but let me know if anything is out of place.

lucaargolo commented 1 year ago

Hey, thanks for the PR! Unfortunately, I can't just add the old blocks in this mod cause it'll make it needed on the server/client. That's why I implemented it in the extras mod. I could use the fix for #107 tho, so if you can open another PR with just that I would happily merge it.

sisby-folk commented 1 year ago

It's a new feature of 2.0 to be able to install this mod just on the server, right? would it be possible to make one release intended for upgrading old worlds (2.0.2) and then another release with this feature immediately removed? (2.0.3)

lucaargolo commented 1 year ago

That's possible but it would be really confusing for a lot of players. You can always just use the custom release of Fabric Extras in the pinned issue to convert your old worlds.

sisby-folk commented 1 year ago

All good then! We'll continue this as a fork for Tinkerer's Quilt because we specifically need backwards save compatibility, but not adding any items (at the same time). Feel free to close this PR and cherry pick the #107 fix!

lucaargolo commented 1 year ago

If you want, you can release it as a standalone mod (just the compat with old blocks). I'll gladly point out to people who have the same problem, and I bet it would help many players.