search

lucaargolo / fabric-seasons

A simple mod for Minecraft that adds seasons to the game, changing biomes as you play.
Mozilla Public License 2.0
64 stars 47 forks source link

Snow and Ice generated from previous version will stay permanently if mod is updated during winter #20

Closed tenguin closed 3 years ago

tenguin commented 3 years ago

There's a potential issue I think you might want to mention in the update notes.

With how the fix is implemented, I believe any region which has recently covered in ice or snow in the old version, will permanently retain all the previously generated vanilla snow and ice blocks if they update the mod while it is still Winter.

Might want to mention that in the notes for people updating; That they might want to stay on the old version and play their game locked to Spring for a while, until they've gotten rid of any stray snow/ice blocks, before updating.

Thanks for fixing that bug, I love this mod ;3

lucaargolo commented 3 years ago

image I think this should do. Thanks for remembering btw!

tenguin commented 3 years ago

rofl, that might be a little too over dramatic. it also might be better worded like this, since the average player would probably get spooked by "break your world" when it's still mostly a cosmetic problem (and fixable by downgrading back to 1.1.x).

"WARNING: IF YOU'RE USING VERSION 1.1.X, MAKE SURE TO SET THE SEASON TO SPRING AND VISIT ALL IMPORTANT LOCATIONS TO GET RID OF ALL THE PREVIOUS ICE AND SNOW IN YOUR WORLD BEFORE UPDATING.

BECAUSE OF A CHANGE IN IMPLEMENTATION, ALL THE ICE AND SNOW FROM WINTER IN THE OLD VERSION WILL NOT MELT IF YOU UPDATE TO THIS VERSION BEFORE IT IS MELTED"