lucaargolo / fabric-seasons

A simple mod for Minecraft that adds seasons to the game, changing biomes as you play.
Mozilla Public License 2.0
64 stars 47 forks source link

All blocks stop rendering when season changes. #24

Closed Bobily8 closed 3 years ago

Bobily8 commented 3 years ago

When the season changes naturally or through the use of commands (either skip season or adding time) all blocks cease rendering. Only entities and particles render. For some reason going through an immersive portal fixes the issue but it breaks again if you relog. Setting the time to 0 also fixes the issue (even when relogging) but only whilst in spring. We have tried fiddling around with render distances/different areas of the world including different accounts and different computers and keep experiencing the issue.

2021-05-12_12 13 44

lucaargolo commented 3 years ago

https://user-images.githubusercontent.com/49497195/118129462-93da6680-b3d2-11eb-9747-0f28d70bad23.mp4

This is for sure caused by something else, maybe a mod incompatibility. I don't even mess with rendering, and as you can see in my video, everything is working fine.

MitztheKat commented 3 years ago

When the season changes naturally or through the use of commands (either skip season or adding time) all blocks cease rendering. Only entities and particles render. For some reason going through an immersive portal fixes the issue but it breaks again if you relog. Setting the time to 0 also fixes the issue (even when relogging) but only whilst in spring. We have tried fiddling around with render distances/different areas of the world including different accounts and different computers and keep experiencing the issue.

2021-05-12_12 13 44

Yo, I think he could assist if you provided logs.

Jakaya0897 commented 3 years ago

I can't help but notice lucaargolo In your demonstration it says Active renderer Indigo Renderer

I'm also experiencing this crippling bug while I'm not sure what logs I can provide as it's not crashing and there are no errors or even mentions to seasons in the log.

I do use sodium and companion performance related mods as well as immersive portals I believe this may be the cause of the issue.

With Seasons: No Weather: 400 FPS With Weather: 0 FPS

Without Seasons No Weather: 400 FPS With Weather: 372 FPS

http://prntscr.com/134d2lc

Sodium-fabric-mc1.16.4-0.1.1-ipc2 Immersive-portals-0.90-mc1.16.5-fabric

I have tested once seasons is removed this behaviour seems to go away, so I'm assuming it's some relationship between your mod and sodium the issue with this is my FPS count will take priority over seasons but id love to have both I'm greedy like that ;)

OarisHunter commented 3 years ago

I have the same issue. While this might also be caused by sodium, immersive portals is the culprit for me.

MorganRO8 commented 3 years ago

If you set your render distance down to 2-3 chunks you should be able to move around, at least that's how it worked for me. After that I did time set 0 and it reset the seasons and completely fixed the issue. This happened on a server for me so me and a few friends experienced it. I'm not 100% sure but I think it might have something to do with resource packs? I'm gonna keep looking but any help on this would be much appreciated.

MorganRO8 commented 3 years ago

I ended up figuring out what I think to be the issue, and @OarisHunter seems to be right it is an issue between seasons and immersive portals. I created an issue on the immersive portals github and they looked into it. Apparently it's cause by the fact that with immersive portals you're loading multiple worlds, that have different seasons apparently, which causes a loop of reloading the renderer. Here's the other issue, it may contain more info than I've summarized https://github.com/qouteall/ImmersivePortalsMod/issues/757 I feel like this should be fixable though, which is sweet!

edit: quote from the original post that seemed relevant "This can only be fixed by Seasons. Seasons can only track the season for the overworld dimension, or track different season data for different dimensions. You can open an issue to Seasons."

TheSpiderDungeon commented 3 years ago

Encountering the same issue, I also have this mod and Immersive Portals installed (with dimension stack active). A fix would be nice so I can play on my world again.

SalvieMundi commented 3 years ago

Any ideas when a fix might be coming for this?

lucaargolo commented 3 years ago

This issue should be fixed on the 1.3-BETA release.