search

lucaargolo / fabric-seasons

A simple mod for Minecraft that adds seasons to the game, changing biomes as you play.
Mozilla Public License 2.0
64 stars 48 forks source link

Seasons colors are mismatched? #8

Closed K0-RR closed 1 year ago

K0-RR commented 3 years ago

1st photo - fall, 2nd - winter. The grass looks more alive in winter than in fall but seems like leaves are set properly. So shouldn't the grass color palette in winter be replaced by the fall palette and vice-versa? 2021-01-27_15 41 47 2021-01-27_15 41 33

lucaargolo commented 3 years ago

Huh weird, I might have mismatched something... If you take a look at the oak leaves you can see the one in the second picture matches the grass color in the first picture. I'll take a look at it.

lucaargolo commented 3 years ago

What biome is this?

K0-RR commented 3 years ago

The one I am in - snowy taiga I think. The camera is pointed at plains.

lucaargolo commented 3 years ago

Hmmm, the biome your camera was pointed at was actually a snowy tundra. (Spruce tree doesn't spawn on regular plains). I took a look at the colormaps and they are in fact correct. What happened is that I wasn't able to fine-tune the color map in a way that allows all the biomes to look good in all seasons. If it really bothers you, you can always make your own custom colormaps using a resource pack. You can also configure exact colors for a specific biome in the mod's config.

realguyman commented 2 years ago

@lucaargolo Serene Seasons was extremely good at determining custom color maps. You could take a loot at their source code and see how they did it: https://github.com/Glitchfiend/SereneSeasons/tree/SS-1.16.x-4.x.x

lucaargolo commented 1 year ago

Heyy. As of version 2.0 all colormaps have been remade.