lucaargolo / kibe

A miscellaneous mod for Minecraft that adds a bunch of random, and mostly unoriginal things.
Mozilla Public License 2.0
46 stars 29 forks source link

Allow random ticks (and more) in chunk loader chunks in player proximity #131

Closed flori-schwa closed 2 years ago

flori-schwa commented 2 years ago

The Mixin removed in this PR prevented calls to:

inside the net.minecraft.server.world.ServerChunkManager#tickChunks method, thus preventing the following in all chunks loaded by kibe, even if players were nearby:

The vanilla behavior of canTickChunk already checks for player proximity, I'm not sure what the initial purpose of this Mixin was, but it was creating some confusion on our modded SMP world.

This behaviour was also submitted as a bug in lucaargolo/kibe#120

lucaargolo commented 2 years ago

Heyy, IIRC the purpose of this mixin is to allow random ticks in chunk-loaded chunks without the need of the player being nearby. At least that was it on 1.16/1.17. I know it's broken on 1.18 but I haven't got the time to fix it yet.

flori-schwa commented 2 years ago

In that case the return value only needs to be changed from false to true

lucaargolo commented 2 years ago

Yeah, looks like the logic got inverted on 1.18, before that it used to return if the player was too far for it to tick.

lucaargolo commented 2 years ago

All chunk loader issues should be fixed in the latest 1.9.5 release! This PR is no longer needed.